DHSS option cannot be set to '<is> True' or '<is> False'

Bug #1647781 reported by Goutham Pacha Ravi
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Won't Fix
Wishlist
Goutham Pacha Ravi

Bug Description

All boolean extra specs in manila can accept <is> operator to match extra-specs. However, the DHSS value and snapshot_support cannot be set to <is> True or <is> False.

stack@openstack2:~$ manila --debug type-create test-type '<is> False'
DEBUG (v2:87) Making authentication request to http://192.168.10.12/identity/v2.0/tokens

REQ: curl -i -X GET http://192.168.10.12:8786/ -H "X-Openstack-Manila-Api-Version: 2.22" -H "X-Auth-Token: de9b90f411d64f6cba5002e8aa4bfe1b" -H "Accept: application/json" -H "User-Agent: python-manilaclient"

DEBUG (httpclient:192)
REQ: curl -i -X GET http://192.168.10.12:8786/ -H "X-Openstack-Manila-Api-Version: 2.22" -H "X-Auth-Token: de9b90f411d64f6cba5002e8aa4bfe1b" -H "Accept: application/json" -H "User-Agent: python-manilaclient"

RESP: [300] {'Date': 'Tue, 06 Dec 2016 16:00:52 GMT', 'Content-Length': '749', 'Content-Type': 'application/json', 'Connection': 'close'}
RESP BODY: {"versions": [{"status": "SUPPORTED", "updated": "2015-08-27T11:33:21Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.10.12:8786/v1/", "rel": "self"}], "min_version": "", "version": "", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.share+json;version=1"}], "id": "v1.0"}, {"status": "CURRENT", "updated": "2015-08-27T11:33:21Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.10.12:8786/v2/", "rel": "self"}], "min_version": "2.0", "version": "2.22", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.share+json;version=1"}], "id": "v2.0"}]}

DEBUG (httpclient:201) RESP: [300] {'Date': 'Tue, 06 Dec 2016 16:00:52 GMT', 'Content-Length': '749', 'Content-Type': 'application/json', 'Connection': 'close'}
RESP BODY: {"versions": [{"status": "SUPPORTED", "updated": "2015-08-27T11:33:21Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.10.12:8786/v1/", "rel": "self"}], "min_version": "", "version": "", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.share+json;version=1"}], "id": "v1.0"}, {"status": "CURRENT", "updated": "2015-08-27T11:33:21Z", "links": [{"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}, {"href": "http://192.168.10.12:8786/v2/", "rel": "self"}], "min_version": "2.0", "version": "2.22", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.share+json;version=1"}], "id": "v2.0"}]}

DEBUG (v2:87) Making authentication request to http://192.168.10.12/identity/v2.0/tokens
DEBUG (shell:689) Argument spec_driver_handles_share_servers argument is not valid: Unrecognized value '<is> False', acceptable values are: '0', '1', 'f', 'false', 'n', 'no', 'off', 'on', 't', 'true', 'y', 'yes'
Traceback (most recent call last):
  File "/opt/stack/python-manilaclient/manilaclient/shell.py", line 684, in main
    map(encodeutils.safe_decode, sys.argv[1:]))
  File "/opt/stack/python-manilaclient/manilaclient/shell.py", line 553, in main
    args.func(self.cs, args)
  File "/opt/stack/python-manilaclient/manilaclient/v2/shell.py", line 2813, in do_type_create
    raise exceptions.CommandError(msg)
CommandError: Argument spec_driver_handles_share_servers argument is not valid: Unrecognized value '<is> False', acceptable values are: '0', '1', 'f', 'false', 'n', 'no', 'off', 'on', 't', 'true', 'y', 'yes'
ERROR: Argument spec_driver_handles_share_servers argument is not valid: Unrecognized value '<is> False', acceptable values are: '0', '1', 'f', 'false', 'n', 'no', 'off', 'on', 't', 'true', 'y', 'yes'

Changed in manila:
importance: Undecided → Medium
tags: added: low-hanging-fruit
yankee (yankeefu)
Changed in manila:
assignee: nobody → yankee (yankeefu)
yankee (yankeefu)
Changed in manila:
status: New → In Progress
yankee (yankeefu)
tags: added: manila-client
removed: low-hanging-fruit
Revision history for this message
yankee (yankeefu) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/413338

Changed in manila:
assignee: yankee (yankeefu) → Hanxi Liu (hanxi-liu)
Changed in manila:
assignee: Hanxi Liu (hanxi-liu) → yankee (yankeefu)
Changed in manila:
milestone: none → pike-3
Changed in manila:
milestone: pike-3 → pike-rc1
Changed in manila:
assignee: yankee (yankeefu) → Goutham Pacha Ravi (gouthamr)
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Retargeting to Rocky-1 based on the APIImpact this would have.

Changed in manila:
milestone: pike-rc1 → rocky-1
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by yankee (yankeefu@163.com) on branch: master
Review: https://review.openstack.org/413338

Changed in manila:
importance: Low → Wishlist
status: In Progress → Won't Fix
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Changed our position on this RFE, the current extra-spec only accepts boolean, and not "<is> True" or "<is> False", and I don't think it significantly improves user experience if these values are allowed on the extra-spec. Please comment/reopen this bug, or hop onto #openstack-manila on freenode, or send us an email on <email address hidden> if you disagree with this stance.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.