parse_is_public function in the API common module should be generic

Bug #1956217 reported by Victoria Martinez de la Cruz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
In Progress
Low
Unassigned

Bug Description

A refactor introduced in commit 3a1e23801fb3a0682101af3f1cc965b1ae7e0379 [0] introduced a documentation bug.

https://github.com/openstack/manila/blob/master/manila/api/common.py#L272-L273 should be

 :rtype: bool
 :returns: True if is_public is None or truthy, None if "all", False otherwise

And

 - None: API should list both public and private share group types

None is assumed being True

See [1] for context

[0] https://review.opendev.org/plugins/gitiles/openstack/manila/+/3a1e23801fb3a0682101af3f1cc965b1ae7e0379
[1] https://review.opendev.org/c/openstack/manila/+/821002

Vida Haririan (vhariria)
tags: added: api
Vida Haririan (vhariria)
Changed in manila:
assignee: nobody → Paul Ali (paulali)
Revision history for this message
Vida Haririan (vhariria) wrote (last edit ):
Changed in manila:
importance: Undecided → Low
Changed in manila:
milestone: yoga-3 → zed-1
Changed in manila:
milestone: zed-1 → zed-2
Changed in manila:
milestone: zed-2 → zed-3
Vida Haririan (vhariria)
Changed in manila:
assignee: Paul Ali (paulali) → nobody
Changed in manila:
assignee: nobody → Fernando Ferraz (fernando-ferraz)
Changed in manila:
milestone: zed-3 → antelope-1
Revision history for this message
Rotense Gabriel (rotense) wrote :

I can fix the documentation bug introduced in [0]

[0] introduced a documentation bug.

Changed in manila:
assignee: Fernando Ferraz (fernando-ferraz) → Rotense Gabriel (rotense)
Revision history for this message
Rotense Gabriel (rotense) wrote (last edit ):

The documentation bug introduced [0] now fixed!

https://review.opendev.org/c/openstack/manila/+/861965

Changed in manila:
status: Triaged → In Progress
Changed in manila:
milestone: antelope-1 → antelope-2
Changed in manila:
milestone: antelope-2 → antelope-rc1
Changed in manila:
assignee: Rotense Gabriel (rotense) → nobody
milestone: antelope-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by "Carlos Eduardo <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/manila/+/861965
Reason: We didn't have many updates on this change, so we are abandoning it. We can revive it some day just in case.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.