OpenStack Shared File Systems Service (Manila)

delete share should not fail on removing affinity hints

Bug #2034925 reported by Maurice Escher
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Triaged
Medium
Chandrakanth Renduchintala

Bug Description

Hi,

what happened?
share A that referenced share B in an anti-affinity rule should be deleted.
That failed with below error.

Reason: share B is no longer existing.

Proposed fix: _delete_scheduler_hints() should catch `NotFound` in addition to already catching `ShareMetadataNotFound``

error from manila shell:
https://paste.opendev.org/show/bu3XA0fMroRPq3AnIuK7/

That was a bit tricky to find out, because the NotFound error bubbled up to the delete request and was very confusing (we took long until we figured out that this is not a permission issue)

BR,
Maurice

Revision history for this message
Vida Haririan (vhariria) wrote :

Hi, Thank you for reporting this issue.
Please add reproduce steps to the bug

tags: added: low-hanging-fruit
Changed in manila:
importance: Undecided → Medium
Revision history for this message
Vida Haririan (vhariria) wrote :

See additional comments at https://meetings.opendev.org/meetings/manila/2023/manila.2023-09-14-15.00.log.html

Vida Haririan (vhariria)
Changed in manila:
status: New → Triaged
Maurice Escher (maurice-escher)
Changed in manila:
assignee: nobody → Maurice Escher (maurice-escher)
Revision history for this message
kizdorothy (kizdorothy) wrote :

Hello, I would like to work on this issue. Hopefully, i can reproduce it.

Revision history for this message
Maurice Escher (maurice-escher) wrote :

Hi, I assigned this to myself because a colleague of mine (a first time contributor) started working on this - downstream the fix is already present (https://github.com/sapcc/manila/pull/144), we just need to bring it up.
Reproducing was not easy, it appeared to be an edge case

Revision history for this message
kizdorothy (kizdorothy) wrote :

Thanks for letting me know, let see what i can work on.

Chandrakanth Renduchintala (crenduchintala88)
Changed in manila:
assignee: Maurice Escher (maurice-escher) → Chandrakanth Renduchintala (crenduchintala88)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.