Unable to configure binding hostname

Bug #2037580 reported by Mohammed Naser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Mohammed Naser

Bug Description

https://github.com/openstack/manila/blob/stable/zed/manila/share/drivers/service_instance.py#L1012-L1033

This codebase uses `gethostname()` by default, in an environment where FQDNs are used for agent names (specified by `host`), no way to override that in Manila.

There should be a flag that allows you to override this.

Changed in manila:
status: New → In Progress
Vida Haririan (vhariria)
Changed in manila:
status: In Progress → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/896692
Committed: https://opendev.org/openstack/manila/commit/809253f3e8ce29b1cefd7afdb8acc1eb476f102c
Submitter: "Zuul (22348)"
Branch: master

commit 809253f3e8ce29b1cefd7afdb8acc1eb476f102c
Author: Mohammed Naser <email address hidden>
Date: Wed Sep 27 17:40:40 2023 +0000

    Respect provided "host" when plugging ports

    When creating port bindings for ports inside Neutron, Manila
    just uses the hostname using "socket.gethostname()" rather
    than the one provided via CONF.host

    The default behaviour of CONF.host is "socket.gethostname()"
    anyways, so it should work just fine.

    Closes-Bug: #2037580
    Change-Id: I4181a6f1527c80bf356d6363300b2d420921e7fa

Changed in manila:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/manila/+/896842

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/manila/+/896843

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/manila/+/896844

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/manila/+/896842
Committed: https://opendev.org/openstack/manila/commit/ee8d0a6c3bcee086e08b1cc442d0aa35d9d4be14
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit ee8d0a6c3bcee086e08b1cc442d0aa35d9d4be14
Author: Mohammed Naser <email address hidden>
Date: Wed Sep 27 17:40:40 2023 +0000

    Respect provided "host" when plugging ports

    When creating port bindings for ports inside Neutron, Manila
    just uses the hostname using "socket.gethostname()" rather
    than the one provided via CONF.host

    The default behaviour of CONF.host is "socket.gethostname()"
    anyways, so it should work just fine.

    Closes-Bug: #2037580
    Change-Id: I4181a6f1527c80bf356d6363300b2d420921e7fa
    (cherry picked from commit 809253f3e8ce29b1cefd7afdb8acc1eb476f102c)

Changed in manila:
importance: Undecided → Medium
assignee: nobody → Mohammed Naser (mnaser)
milestone: none → caracal-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/manila/+/896844
Committed: https://opendev.org/openstack/manila/commit/44035950c6650407b32a162bc8fa03833a984877
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 44035950c6650407b32a162bc8fa03833a984877
Author: Mohammed Naser <email address hidden>
Date: Wed Sep 27 17:40:40 2023 +0000

    Respect provided "host" when plugging ports

    When creating port bindings for ports inside Neutron, Manila
    just uses the hostname using "socket.gethostname()" rather
    than the one provided via CONF.host

    The default behaviour of CONF.host is "socket.gethostname()"
    anyways, so it should work just fine.

    Closes-Bug: #2037580
    Change-Id: I4181a6f1527c80bf356d6363300b2d420921e7fa
    (cherry picked from commit 809253f3e8ce29b1cefd7afdb8acc1eb476f102c)

tags: added: in-stable-zed
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

We're introducing a new config option to facilitate the separation of the network host and manila storage host config..

    https://review.opendev.org/c/openstack/manila/+/897077

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/manila/+/896843
Committed: https://opendev.org/openstack/manila/commit/2e2ab95b8b240e8d1a51d0a20a220e525ea092b1
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 2e2ab95b8b240e8d1a51d0a20a220e525ea092b1
Author: Mohammed Naser <email address hidden>
Date: Wed Sep 27 17:40:40 2023 +0000

    Respect provided "host" when plugging ports

    When creating port bindings for ports inside Neutron, Manila
    just uses the hostname using "socket.gethostname()" rather
    than the one provided via CONF.host

    The default behaviour of CONF.host is "socket.gethostname()"
    anyways, so it should work just fine.

    Closes-Bug: #2037580
    Change-Id: I4181a6f1527c80bf356d6363300b2d420921e7fa
    (cherry picked from commit 809253f3e8ce29b1cefd7afdb8acc1eb476f102c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 16.1.0

This issue was fixed in the openstack/manila 16.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 17.1.0

This issue was fixed in the openstack/manila 17.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 15.3.0

This issue was fixed in the openstack/manila 15.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.