marionnet

Compile error with ocaml 3.12.0

Bug #745779 reported by cdemoulins on 2011-03-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	marionnet	Fix Committed	High	Unassigned

Bug Description

I'm trying to compile marionnet on Archlinux using the last version of ocaml (3.12.0) and i have some errors :

% make
Just for debugging: PP_OPTION is "camlp4of -I /usr/lib/ocaml/ocamlbricks gettext_extract_pot_p4.cmo option_extract_p4.cmo raise_p4.cmo log_module_loading_p4.cmo -I chip"
Building meta.ml...
Success.
Manually pre-copying "gettext_extract_pot_p4.conf"...
Manually pre-copying "chip/chip_parser_p4.ml"...
Manually pre-copying "scripts/can-directory-host-sparse-files.sh"...
Manually pre-building "chip/chip_parser_p4.cmo"...
make[1]: entrant dans le répertoire « /var/abs/local/marionnet/marionnet-0.90.6 »
File "chip/chip_parser_p4.ml", line 52, characters 69-72:
While expanding quotation "ctyp" in a position of "expr":
Parse error: EOI expected after [quotation of type] (in [quotation of type])

File "chip/chip_parser_p4.ml", line 1, characters 0-1:
Error: Preprocessor error

After some investigation (see this bug: http://caml.inria.fr/mantis/view.php?id=5080) i wrote a patch to fix this problem and it seem to solve the problem but i'm not an ocaml expert.

Revision history for this message

cdemoulins (cdemoulins) wrote on 2011-03-30:

ocaml-3.12.patch Edit (2.1 KiB, text/plain)

Revision history for this message

Luca Saiu (saiu) wrote on 2011-03-30:

Thanks, this is very useful.
By the way, I think you're the first one officially submitting a patch. That's braggable :-).

We're gonna test your change tomorrow on old and new versions of OCaml before committing it, but your change seems very reasonable.

Thanks again,

Changed in marionnet:
importance:	Undecided → High
status:	New → Triaged

Revision history for this message

Luca Saiu (saiu) wrote on 2011-04-01:

Hello Clément. Your patch fixes compilation and looks definitely correct, but compatibility with OCaml 3.12 is apparently more difficult; at least on my machine our recursive mutex implementation from OCamlbricks misbehaves under 3.12 for some reason we didn't quite understand yet, which makes Marionnet hang very soon at startup.

I've applied your patch, together with some buildsystem changes of mine which are intended to be backwards-compatible, in new branches named "porting-to-ocaml-3.12", for both Marionnet and OCamlbricks; as soon as we get to fix the recursive mutex problem we will be able to merge back into trunk.

Thanks again,

Changed in marionnet:
status:	Triaged → Fix Committed

Revision history for this message

cdemoulins (cdemoulins) wrote on 2011-04-02:

Ok, i confirm, i still have some problem when i launch the client. I tried to activate the debug mode but there are no errors or warnings.
For now i'm using the script marionnet_from_scratch to compile and it's working on Archlinux but i cannot provide a package.