Midori Web Browser

[AppMenu] don't show "customize toolbar"

Bug #699933 reported by Danielle Foré on 2011-01-07

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Midori Web Browser	Fix Released	Low	Danielle Foré

Bug Description

The entry "customize toolbar" created by the toolbar editor extension should appear in the toolbar context menu instead of the AppMenu.

Tags:

Danielle Foré (danrabbit) on 2011-01-11

Changed in midori:
importance:	Undecided → Low

Danielle Foré (danrabbit) on 2011-02-01

tags:

added: bitesize

Revision history for this message

Cris Dywan (kalikiana) wrote on 2011-02-01:

A function may need to be added to MidoriBrowser so the extension can do this.

Changed in midori:
status:	New → Confirmed

Revision history for this message

Danielle Foré (danrabbit) wrote on 2011-02-01:

ah okay, maybe not so bitesize. pulling the tag.

tags:

removed: bitesize

Michael Moroni (airon90) on 2011-02-02

tags:

added: appmenu toolbar

Revision history for this message

Tomasz Szatkowski (szatkus) wrote on 2011-03-13:

customize.diff Edit (3.9 KiB, text/plain)

I added new signal ("populate-toolbar-menu") and left "customize toolbar" item in tools. Now this option is both in tools menu and toolbar context menu, but I shortened the second version to "customize".

Revision history for this message

Cris Dywan (kalikiana) wrote on 2011-03-18:

The menu item needs to say "Customise..." with periods to indicate that it shows a dialogue. Also I think it needs a separator, otherwise I can't tell that it's not another check mark.

Part of the issue is not addressed: it should no longer show up in the tools/ app menu. This may however be slightly confusing to upgrading users, not entirely sure if that's an issue.

In terms of code, please respect the coding style used in the toolbar editor, ie. tabs rather than spaces. Looking at the style of the function is generally good measure if you're unsure.

Changed in midori:
assignee:	nobody → Tomasz Szatkowski (szatkus)
status:	Confirmed → In Progress

Revision history for this message

Tomasz Szatkowski (szatkus) wrote on 2011-03-23:

customize.diff Edit (4.3 KiB, text/plain)

Done.

Revision history for this message

Cris Dywan (kalikiana) wrote on 2011-04-17:

Very nice, thanks a lot.

Changed in midori:
status:	In Progress → Fix Committed

Cris Dywan (kalikiana) on 2011-05-03

Changed in midori:
status:	Fix Committed → Fix Released

Revision history for this message

Danielle Foré (danrabbit) wrote on 2012-06-25:

Reopening this report since it was originally about removing the entry from the AppMenu.

Changed in midori:
status:	Fix Released → New
assignee:	Tomasz Szatkowski (szatkus) → nobody

Danielle Foré (danrabbit) on 2012-06-26

Changed in midori:
assignee:	nobody → Daniel Fore (danrabbit)
status:	New → In Progress

Revision history for this message

Cris Dywan (kalikiana) wrote on 2012-06-26:

Indeed, we have the context menu, the app menu item can go away.

Revision history for this message

Cris Dywan (kalikiana) wrote on 2012-06-28:

Thanks for the fix! Committed.

Changed in midori:
status:	In Progress → Fix Committed

Cris Dywan (kalikiana) on 2012-09-20

Changed in midori:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Related blueprints

Clean up Midori Menus

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.