Unnecessary implementation in geometry headers
Bug #1247820 reported by
Alan Griffiths
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Alan Griffiths | ||
mir (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
geometry/
The costs: pulling in <ostream> and compilation when not used and de-duplication when used.
Better would be use of <iosfwd> and an implementation file (I'd be happy for all the geometry operator<<() functions to be in one file.)
Related branches
lp://qastaging/~alan-griffiths/mir/fix-1247820
- Daniel van Vugt: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 223 lines (+71/-36)9 files modifiedexamples/CMakeLists.txt (+1/-0)
include/shared/mir/geometry/displacement.h (+2/-6)
include/shared/mir/geometry/point.h (+2/-7)
include/shared/mir/geometry/rectangle.h (+2/-7)
include/shared/mir/geometry/size.h (+2/-7)
src/server/CMakeLists.txt (+1/-0)
src/shared/geometry/CMakeLists.txt (+1/-0)
src/shared/geometry/ostream.cpp (+60/-0)
src/shared/geometry/rectangles.cpp (+0/-9)
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
status: | New → In Progress |
summary: |
- Unnecessary implementation in headers + Unnecessary implementation in geometry headers |
Changed in mir: | |
importance: | Undecided → Low |
milestone: | none → 0.1.2 |
Changed in mir: | |
status: | In Progress → Fix Committed |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in mir (Ubuntu): | |
status: | Triaged → Fix Committed |
To post a comment you must log in.
This bug was fixed in the package mir - 0.1.2+14. 04.20131128. 1-0ubuntu1
--------------- 14.04.20131128. 1-0ubuntu1) trusty; urgency=low
mir (0.1.2+
[ Kevin Gunn ] library. h: Fix typo "do and locking" should be "do any communication_ package: Do not expect opened fd to be >0, desktop- mir. :MirSurface) .
* New upstream release 0.1.2
- graphics: android: improve interface for mga::DisplayDevice so its
just concerned with rendering and posting.
- surfaces: rename "surfaces" component to "scene".
- surfaces, shell: Migrate Session data model from shell to surfaces.
- graphics: change fill_ipc_package() to use real pointers.
- mir_client_
locking".
- API enumerations cleanup: Remove slightly misleading *_enum_max_
values, and replace them with more accurate plural forms.
- test_android_
we may have closed stdin making this a valid value (LP: #1247718).
- Update docs about running Mir on the desktop to mention new package
ubuntu-
- offscreen: Add a display that renders its output to offscreen buffers
- graphics: android: fix regression for hwc1.0 devices introduced in r1228
(LP: #1252433).
- OffscreenPlatform provides the services that the offscreen display
needs from the Platform.
- graphics: android: consolidate the GLContexts classes in use.
- Fix uninitialized variable causing random drm_auth_magic test
failures. (LP: #1252144).
- Add a fullyish functional Udev wrapper. This currently sits in
graphics/gbm, but will be moved to the top-level when input device
detection migrates.
- Add resizing support to example code; demo-shell and clients.
- eglapp: Clarify messages about pixel formats (LP: #1168304).
- Adds support to the MirMotionEvent under pointer_coordinates called
tool_type. This will allow clients to tell what type of tool is
being used, from mouse/finger/etc. (LP: #1252498)
- client,frontend: Report the real available surface pixel formats to
clients. (LP: #1240833)
- graphics: android: 1) change hwc1.1 to make use of sync fences during
the compositor's gl renderloop. Note that we no longer wait for the
render to complete, we pass this responsibility to the driver and the
kernel. 2) support nexus 10. (LP: #1252173) (LP: #1203268)
- shell: don't publish SurfacesContainer - it can be private to shell.
- gbm: Don't mess up the VT mode on setup failure Only restore the
previous VT mode during shutdown if it was VT_AUTO.
- Fix a crash due to a failed eglMakeCurrent() call when in nested mode.
- shell: unity-mir uses shell::FocusSetter - make the header public again
- Add resize support to client surfaces (mir::client:
- graphics: android: support 'old aka 2012' nexus 7 hwc (nvidia tegra3
SoC) better. (LP: #1231917)
- Add resize support to *ClientBuffer classes. Now always get dimensions
from the latest buffer package.
- android: support driver hooks for the Mali T604 (present in nexus 10)
- Add width and height to the protocol Buffer messages, in preparation
for resizable surfaces.
- surfaces, shell, logging, te...