Nested servers prevent overlays or fullscreen bypass from working
Bug #1262116 reported by
Daniel van Vugt
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Kevin DuBois | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Nested servers prevent fullscreen bypass from working.
This would explain why nesting fullscreen clients is measurably slower than non-nesting:
Direct (bypass) 2600
Direct (bypass off) 2400
Nested (bypass) 2450
Nested (bypass off) 2330
Related branches
lp://qastaging/~kdub/mir/nested-passthrough
- Daniel van Vugt: Approve
- Cemil Azizoglu (community): Approve
- Mir CI Bot: Approve (continuous-integration)
-
Diff: 918 lines (+376/-43)27 files modifiedinclude/test/mir_test_framework/any_surface.h (+3/-1)
include/test/mir_test_framework/headless_display_buffer_compositor_factory.h (+5/-0)
include/test/mir_test_framework/headless_nested_server_runner.h (+12/-0)
src/client/atomic_callback.h (+3/-3)
src/client/mir_buffer_api.cpp (+2/-0)
src/server/compositor/buffer_map.cpp (+8/-4)
src/server/compositor/buffer_map.h (+3/-1)
src/server/graphics/nested/buffer.cpp (+1/-1)
src/server/graphics/nested/host_connection.h (+1/-0)
src/server/graphics/nested/host_surface_spec.h (+2/-0)
src/server/graphics/nested/ipc_operations.h (+2/-2)
src/server/graphics/nested/mir_client_host_connection.cpp (+192/-5)
src/server/graphics/nested/mir_client_host_connection.h (+1/-0)
src/server/graphics/nested/native_buffer.h (+0/-1)
src/server/graphics/nested/platform.cpp (+52/-2)
tests/acceptance-tests/test_nested_mir.cpp (+17/-0)
tests/include/mir/test/doubles/stub_client_buffer.h (+6/-1)
tests/include/mir/test/doubles/stub_host_connection.h (+5/-0)
tests/integration-tests/test_buffer_scheduling.cpp (+3/-3)
tests/mir_test_framework/any_surface.cpp (+7/-1)
tests/mir_test_framework/headless_display_buffer_compositor_factory.cpp (+22/-2)
tests/mir_test_framework/headless_nested_server_runner.cpp (+17/-3)
tests/mir_test_framework/headless_test.cpp (+1/-1)
tests/unit-tests/compositor/test_client_buffers.cpp (+10/-10)
tests/unit-tests/platforms/nested/test_buffer.cpp (+1/-0)
tests/unit-tests/platforms/nested/test_ipc_operations.cpp (+0/-1)
tests/unit-tests/platforms/nested/test_nested_display_buffer.cpp (+0/-1)
summary: |
- Nested servers prevent full bypass from working + Nested servers prevent fullscreen bypass from working |
description: | updated |
description: | updated |
Changed in mir: | |
assignee: | nobody → Alexandros Frantzis (afrantzis) |
milestone: | none → 0.13.0 |
status: | Triaged → In Progress |
Changed in mir: | |
assignee: | Alexandros Frantzis (afrantzis) → Kevin DuBois (kdub) |
Changed in mir: | |
milestone: | 0.13.0 → 0.14.0 |
tags: | added: overlays |
Changed in mir: | |
milestone: | 0.14.0 → 0.15.0 |
Changed in mir: | |
milestone: | 0.15.0 → 0.16.0 |
Changed in mir: | |
milestone: | 0.16.0 → 0.17.0 |
Changed in mir: | |
milestone: | 0.17.0 → 0.18.0 |
Changed in mir: | |
milestone: | 0.18.0 → 0.19.0 |
Changed in mir: | |
milestone: | 0.19.0 → 0.20.0 |
Changed in mir: | |
milestone: | 0.20.0 → none |
Changed in mir: | |
milestone: | none → 0.20.0 |
Changed in mir: | |
milestone: | 0.20.0 → 0.21.0 |
Changed in mir: | |
milestone: | 0.21.0 → 0.22.0 |
Changed in mir: | |
milestone: | 0.22.0 → none |
Changed in mir: | |
milestone: | none → 0.23.0 |
Changed in mir: | |
milestone: | 0.23.0 → 0.24.0 |
Changed in mir: | |
milestone: | 0.24.0 → none |
Changed in mir: | |
milestone: | none → 0.25.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Verified not implemented yet:
bool mgn::detail: :NestedOutput: :post_renderabl es_if_optimizab le(RenderableLi st const&)
{
return false;
}