Tests that use the InProcessServer bind the default socket file
Bug #1271604 reported by
Alexandros Frantzis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Alan Griffiths | ||
| mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
Tests that use the InProcessServer should use only in process communication pathways (socketpair etc), but end up opening and binding the default socket file anyway. This was found by accident when crashing a test that uses InProcessServer, leaving the default socket file in the file system and being unable to run the test again.
See line 505 in http://
Related branches
lp://qastaging/~alan-griffiths/mir/fix-1271604
- Daniel van Vugt: Approve
- Kevin DuBois (community): Approve
- Andreas Pokorny (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 50 lines (+15/-0)2 files modifiedinclude/test/mir_test_framework/in_process_server.h (+2/-0)
tests/mir_test_framework/in_process_server.cpp (+13/-0)
Revision history for this message
| Alexandros Frantzis (afrantzis) wrote | #1 |
| Changed in mir: | |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
| Changed in mir: | |
| status: | New → Confirmed |
| Changed in mir: | |
| milestone: | none → 0.1.5 |
| status: | Confirmed → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #2 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #3 |
| Changed in mir (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | New → Fix Released |
| Changed in mir: | |
| importance: | Undecided → Medium |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
To easily reproduce: touch /run/user/$(id -u)/mir_socket