nexus 10 crashes with std::exception::what: error during hwc set()
Bug #1278658 reported by
Kevin DuBois
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Critical
|
Kevin DuBois | ||
mir (Ubuntu) |
Fix Released
|
Critical
|
Unassigned |
Bug Description
I tested the nexus 10 when landing r1383 for tears/etc, but found today that it crashes in long-running situations with:
std::exception:
Related branches
lp://qastaging/~kdub/mir/fix-1278658
- PS Jenkins bot (community): Approve (continuous-integration)
- Alexandros Frantzis (community): Approve
- Chris Halse Rogers: Approve
- Daniel van Vugt: Approve
-
Diff: 38 lines (+9/-2)2 files modifiedsrc/platform/graphics/android/hwc_layers.cpp (+2/-1)
tests/unit-tests/graphics/android/test_hwc_layers.cpp (+7/-1)
Changed in mir: | |
status: | New → In Progress |
Changed in mir (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Critical |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The cause was that we were leaking fence fd's, eventually causing the kernel to return an error code during set. Specifically, we were setting the acquireFenceFd for the framebuffer skip layer by duping the buffer fd. This is incorrect according to the hwc header comments because the HWC_FRAMEBUFFER layers should have their fences ignored.