Mir

Memory errors in unit tests under valgrind on armhf

Bug #1279438 reported by Alexandros Frantzis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Alexandros Frantzis
Mir 0.1.6
mir (Ubuntu)
Fix Released
High
Unassigned

Bug Description

The Mir unit tests fail under valgrind on armhf because of spurious memory errors, most likely caused by external (to Mir) code (the dynamic linker, as an example). We aren't getting failures in CI currently, because we are ignoring valgrind errors on android.

An MP that changes this (among other things it does related to platform) is blocked by this issue. The short term solution is to disable running the tests under valgrind for armhf in CI, but it's imperative that we take care of the issue properly.

Tags: testsfail

Related branches

lp://qastaging/~afrantzis/mir/valgrind-suppressions-armhf
Alexandros Frantzis (community): Abstain
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Approve
Kevin DuBois (community): Abstain
Alan Griffiths: Approve
Diff: 371 lines (+166/-19)
6 files modified
CMakeLists.txt (+5/-1)
cmake/MirCommon.cmake (+8/-4)
cmake/src/mir/mir_discover_gtest_tests.cpp (+24/-10)
include/test/mir_test_doubles/mock_hwc_composer_device_1.h (+2/-0)
tests/unit-tests/test_udev_wrapper.cpp (+16/-4)
tools/valgrind_suppressions_armhf (+111/-0)
lp://qastaging/ubuntu/trusty-proposed/mir
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Note that this is not the same as bug 1279438 which refers specifically to memory leaks (which we aren't catching in CI at all on any platform).

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Using:
   valgrind --trace-children=yes bin/mir_unit_tests
on Nexus 10 I can't reproduce any failures:

   [==========] 833 tests from 142 test cases ran. (116502 ms total)
   [ PASSED ] 833 tests.

But the valgrind summary is not good:

    ==4714== ERROR SUMMARY: 1117583 errors from 582 contexts (suppressed: 200679 from 160)

That said, most of it appears to be unrelated to Mir code. Can you provide more details of what's failing?

tags: added: testsfail
Changed in mir:
status: New → Incomplete
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> Using: valgrind --trace-children=yes bin/mir_unit_tests on Nexus 10 I can't reproduce any failures:

Sorry, I wasn't clear: the individual unit tests themselves don't fail, but the tests as a whole fail when run under valgrind because of the memory errors (i.e. valgrind --error-exitcode=1 ... returns 1).

Alexandros Frantzis (afrantzis)
Changed in mir:
assignee: nobody → Alexandros Frantzis (afrantzis)
Daniel van Vugt (vanvugt)
Changed in mir:
status: Incomplete → New
kevin gunn (kgunn72)
Changed in mir:
status: New → In Progress
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.1.6
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision 1419, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This bug was fixed in the package mir - 0.1.6+14.04.20140310-0ubuntu1
---------------
mir (0.1.6+14.04.20140310-0ubuntu1) trusty; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → High
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.