Mir

--launch-client option locks up DRM

Bug #1284081 reported by Alan Griffiths
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Alexandros Frantzis
Mir 0.1.6
mir (Ubuntu)
Fix Released
High
Unassigned

Bug Description

$ sudo bin/mir_demo_server_basic --launch-client bin/mir_demo_client_eglplasma

[Exit server using e.g. Ctrl+Alt+Backspace]

$ sudo bin/mir_demo_server_basic
ERROR: /home/alan/display_server/mir4/src/platform/graphics/mesa/display_helpers.cpp(234): Throw in function int mir::graphics::mesa::helpers::DRMHelper::open_drm_device(const std::shared_ptr<mir::udev::Context>&)
Dynamic exception type: boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::runtime_error> >
std::exception::what: Error opening DRM device
-22, "Unknown error -22"

The problem doesn't arise if starting the client separately. So I guess using "system()" to start it allows too much to leak between processes.

NB this issue also blocks switching back to X

Related branches

lp://qastaging/~afrantzis/mir/drm-device-fd-close-on-exec
Daniel van Vugt: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Alan Griffiths: Approve
Diff: 221 lines (+89/-10)
7 files modified
include/test/mir_test_doubles/mock_drm.h (+1/-0)
src/platform/graphics/mesa/display_helpers.cpp (+8/-1)
tests/mir_test_doubles/mock_drm.cpp (+7/-4)
tests/unit-tests/graphics/mesa/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/mesa/test_display.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_drm_helper.cpp (+65/-0)
tests/unit-tests/graphics/mesa/test_platform.cpp (+6/-4)
lp://qastaging/ubuntu/trusty-proposed/mir
Alan Griffiths (alan-griffiths)
affects: mir (Ubuntu) → mir
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

The problem can be avoided by ensuring that the client exits before the server.

kevin gunn (kgunn72)
Changed in mir:
importance: Undecided → High
status: New → Triaged
Daniel van Vugt (vanvugt)
summary: - "mir_demo_basic_server --launch-client" locks up DRM
+ --launch-client option locks up DRM
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Linked a branch, but apparently that's not the complete fix.

Changed in mir:
assignee: nobody → Alexandros Frantzis (afrantzis)
status: Triaged → In Progress
milestone: none → 0.1.6
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Workaround: Kill the orphaned Mir demo that's holding DRM open:
sudo killall -9 mir_demo_standalone_render_surfaces

Then everything seems to work again.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This bug was fixed in the package mir - 0.1.6+14.04.20140310-0ubuntu1
---------------
mir (0.1.6+14.04.20140310-0ubuntu1) trusty; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → High
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.