Mir

[enhancement] screencast of a single window

Bug #1288478 reported by Adrian Wechner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Alberto Aguirre
Mir 0.1.7
mir (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

I'd like to request a feature.

- To define a "window" which then will be captured. Automatically selecting the window size as its capture-size.

- Also video capturing of the window. So even if the window is moved around with the mouse, then the capturing continous capturing the window's relative position.

Thanks

Tags: enhancement

Related branches

lp://qastaging/~albaguirre/mir/add-screencast-size-and-region-support
Alan Griffiths: Approve
Daniel van Vugt: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Alexandros Frantzis (community): Approve
Diff: 1211 lines (+335/-247)
19 files modified
include/server/mir/frontend/screencast.h (+3/-1)
include/shared/mir_toolkit/client_types.h (+23/-3)
include/test/mir_test_doubles/mock_screencast.h (+4/-2)
include/test/mir_test_doubles/null_screencast.h (+3/-1)
src/client/CMakeLists.txt (+1/-0)
src/client/mir_screencast.cpp (+20/-23)
src/client/mir_screencast.h (+4/-2)
src/client/mir_screencast_api.cpp (+9/-19)
src/server/compositor/compositing_screencast.cpp (+14/-37)
src/server/compositor/compositing_screencast.h (+6/-4)
src/server/compositor/screencast_display_buffer.cpp (+3/-2)
src/server/frontend/session_mediator.cpp (+9/-4)
src/shared/protobuf/mir_protobuf.proto (+9/-1)
src/utils/screencast.cpp (+14/-12)
tests/acceptance-tests/test_client_screencast.cpp (+72/-39)
tests/integration-tests/client/test_screencast.cpp (+5/-1)
tests/unit-tests/client/test_mir_screencast.cpp (+91/-79)
tests/unit-tests/compositor/test_compositing_screencast.cpp (+28/-17)
tests/unit-tests/compositor/test_screencast_display_buffer.cpp (+17/-0)
lp://qastaging/~albaguirre/mir/add-extra-options-to-mirscreencast
Kevin DuBois (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Alan Griffiths: Approve
Alexandros Frantzis (community): Approve
Diff: 344 lines (+157/-74)
1 file modified
src/utils/screencast.cpp (+157/-74)
lp://qastaging/ubuntu/trusty-proposed/mir
Adrian Wechner (adrian-wechner)
information type: Public → Public Security
information type: Public Security → Public
summary: - [feature] screencapture of a single window
+ [feature] screencast of a single window
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The branch up for review right now is a start, but more will be required to completely implement this enhancement.

Changed in mir:
status: New → In Progress
assignee: nobody → Alberto Aguirre (albaguirre)
milestone: none → 0.1.7
summary: - [feature] screencast of a single window
+ [enhancement] screencast of a single window
tags: added: enhancement
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

See also performance bug 1280938

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Come to think of it, if we could exclusively screencast one particular surface at a time then there's no need for any recompositing at all (!)

Revision history for this message
Adrian Wechner (adrian-wechner) wrote :

Are you actually recompositing the whole screen just for the screencasting?
Isn't it easier to just copy the already finished composited buffer and copy out the section you need for it? (instead of re-compositing all? Sounds to me that re-compositing represents 3 times more load then to copy and copy out what you need... what do you think about that?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I don't know for sure. I haven't looked at that code since it landed. Only heard that it was re-composition, but that might not be accurate.

Daniel van Vugt (vanvugt)
Changed in mir:
importance: Undecided → Medium
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision 1465, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown

Revision history for this message
Adrian Wechner (adrian-wechner) wrote :

I'd like to point out that this specific enhancement is not implemented yet.

Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.3 KiB)

This bug was fixed in the package mir - 0.1.7+14.04.20140317.1-0ubuntu1

---------------
mir (0.1.7+14.04.20140317.1-0ubuntu1) trusty; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.1.7 (https://launchpad.net/mir/+milestone/0.1.7)
    - mirserver ABI bumped to 17
    - mirclient ABI unchanged, still at 7. Clients do not need rebuilding.
    - Server API changes (AKA why doesn't my code build any more?):
      . Class "CompositingCriteria" has been removed. It's replaced by the more
        flexible "Renderable" interface. This also resulted in parameter
        changes for the Renderer and scene filtering classes.
      . The function "DisplayConfiguration::configure_output()" has been
        removed. Instead, please use the new mutable version of
        "DisplayConfiguration::for_each_output()" with which you can modify
        the output structure passed in on each iteration.
      . Exposed formerly private class "GLRenderer" and demonstrated how
        to override its behaviour in demo-shell. This area is under
        construction and may experience further major changes.
    - Added initial support for hardware (HWC) overlays to accelerate
      rendering and reduce power consumption. Not complete yet.
    - Screen rotation: Added mouse cursor rotation support, so you can now
      still control things on a rotated screen. Still missing rotation of
      the cursor bitmap itself.
    - Lots of fixes to support nested Mir servers (see below).
    - Major simplification to how surface size/position/transformation
      interact, making transformations much easier to manage and work with.
    - Bugs fixed:
      . ./cross-compile-chroot.sh: line 83: popd: build-android-arm: invalid
        argument popd: usage: popd [-n] [+N | -N] (LP: #1287600)
      . Key events sent to the wrong client (and delayed) (LP: #1213804)
      . Nested servers never receive input events (in their filters)
        (LP: #1260612)
      . Software clients crash immediately on nested servers - what(): Failed
        to mmap buffer (LP: #1261286)
      . MirMotionEvent lacks local coordinates. Reports only screen
        coordinates. (LP: #1268819)
      . Nested Mir crashes with - what():
        MesaNativePlatform::create_internal_client is not implemented yet!
        (LP: #1279092)
      . clients fail to find some libraries if mir installed via "make install"
        (LP: #1285566)
      . Nested server hangs with multimonitor and internal clients.
        (LP: #1287282)
      . [regression] Multi-monitor frame sync no longer works (not
        synchronized), and frames skip/jump/stutter (LP: #1288570)
      . Mir FTBFS: /usr/bin/ld: cannot find -lmirtestdraw (when cmake ..
        -DMIR_ENABLE_TESTS=OFF) (LP: #1283951)
      . nested Mir library calls next_buffer() during startup (LP: #1284739)
      . Building Mir produces lots of warnings from GLM headers about
        deprecated degrees values vs radians (LP: #1286010)
      . [enhancement] screencast of a single window (LP: #1288478)
      . Nexus4 + mir_demo_client_eglplasma starts to stutter after a while
        (LP: #1189753)
      . --host-socket documented default argument isn't...

Read more...

Changed in mir (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.