Mir

Subpixel order not included in Mir display information

Bug #1393578 reported by Robert Carr
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Chris Halse Rogers
Mir 0.27.0
0.26
Fix Released
Medium
Mir development team
Mir 0.26.2
mir (Ubuntu)
Fix Released
Medium
Unassigned
qtmir (Ubuntu)
Triaged
Medium
Unassigned
qtubuntu (Ubuntu)
Triaged
Medium
Unassigned
xorg-server (Ubuntu)
Won't Fix
Medium
Daniel van Vugt

Bug Description

Just capturing something mentioned by Trevinho on IRC this morning. MirDisplayOutput does not include subpixel ordering, it could and should though. The information is exposed on the drm side (drmModeSubPixel). Marking as wishlist in absence of other information.

Related branches

lp://qastaging/~raof/mir/plumb-subpixel-info
Mir CI Bot: Approve (continuous-integration)
Cemil Azizoglu (community): Approve
Daniel van Vugt: Approve
Kevin DuBois (community): Approve
Diff: 690 lines (+218/-42)
25 files modified
include/client/mir_toolkit/mir_display_configuration.h (+9/-0)
include/common/mir_toolkit/common.h (+16/-0)
include/platform/mir/graphics/display_configuration.h (+4/-0)
include/test/mir/test/doubles/stub_display_configuration.h (+22/-2)
src/client/display_configuration_api.cpp (+7/-0)
src/client/symbols.map (+1/-0)
src/platform/graphics/display_configuration.cpp (+2/-1)
src/platforms/android/server/display_configuration.cpp (+3/-1)
src/platforms/android/server/fb_device.cpp (+2/-1)
src/platforms/android/server/hwc_blanking_control.cpp (+2/-1)
src/platforms/mesa/server/kms/real_kms_display_configuration.cpp (+1/-1)
src/platforms/mesa/server/x11/graphics/display_configuration.cpp (+2/-1)
src/protobuf/mir_protobuf.proto (+1/-0)
src/server/frontend/protobuf_buffer_packer.cpp (+1/-0)
src/server/graphics/nested/nested_display_configuration.cpp (+6/-4)
src/server/graphics/nested/nested_display_configuration.h (+1/-0)
tests/acceptance-tests/test_new_display_configuration.cpp (+44/-0)
tests/mir_test/display_config_matchers.cpp (+6/-3)
tests/mir_test_doubles/stub_display_configuration.cpp (+56/-11)
tests/unit-tests/graphics/mesa/kms/test_cursor.cpp (+6/-3)
tests/unit-tests/graphics/mesa/kms/test_display_configuration.cpp (+18/-9)
tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+2/-1)
tests/unit-tests/graphics/test_display_configuration.cpp (+2/-1)
tests/unit-tests/graphics/test_overlapping_output_grouping.cpp (+2/-1)
tests/unit-tests/scene/test_mediating_display_changer.cpp (+2/-1)
lp://qastaging/~raof/mir/subpixel-info-for-mesa-kms
Mir CI Bot: Approve (continuous-integration)
Kevin DuBois (community): Approve
Cemil Azizoglu (community): Approve
Diff: 244 lines (+177/-3)
4 files modified
src/platforms/mesa/server/kms/real_kms_display_configuration.cpp (+23/-1)
tests/include/mir/test/doubles/mock_drm.h (+2/-1)
tests/mir_test_doubles/mock_drm.cpp (+3/-1)
tests/unit-tests/graphics/mesa/kms/test_display_configuration.cpp (+149/-0)
lp://qastaging/~vanvugt/mir/nested-subpixel-arrangement
Chris Halse Rogers: Approve
Mir CI Bot: Approve (continuous-integration)
Kevin DuBois (community): Approve
Diff: 93 lines (+27/-6)
4 files modified
src/server/graphics/nested/nested_display_configuration.cpp (+8/-5)
src/server/graphics/nested/nested_display_configuration.h (+1/-1)
tests/unit-tests/platforms/nested/mir_display_configuration_builder.cpp (+2/-0)
tests/unit-tests/platforms/nested/test_nested_display_configuration.cpp (+16/-0)
lp://qastaging/~vanvugt/mir/set-subpixel
On hold for merging into lp://qastaging/mir
Chris Halse Rogers: Disapprove
Mir CI Bot: Approve (continuous-integration)
Diff: 195 lines (+115/-1)
6 files modified
include/client/mir_toolkit/mir_display_configuration.h (+12/-0)
src/client/display_configuration_api.cpp (+6/-0)
src/client/symbols.map (+1/-0)
src/server/frontend/session_mediator.cpp (+2/-1)
src/utils/out.c (+38/-0)
tests/acceptance-tests/test_new_display_configuration.cpp (+56/-0)
lp://qastaging/~mir-team/mir/0.26-old
Michał Sawicz: Disapprove
Diff: 13 lines (+6/-0)
1 file modified
debian/changelog (+6/-0)
lp://qastaging/~ci-train-bot/mir/mir-ubuntu-zesty-2600 (Merged)
lp://qastaging/~ci-train-bot/mir/mir-ubuntu-zesty-2609
lp://qastaging/~ci-train-bot/mir/mir-ubuntu-zesty-2683
lp://qastaging/~ci-train-bot/mir/mir-ubuntu-xenial-2736
lp://qastaging/~ci-train-bot/mir/mir-ubuntu-yakkety-2783.1
lp://qastaging/~ci-train-bot/mir/mir-ubuntu-yakkety-2783
lp://qastaging/~ci-train-bot/mir/mir-ubuntu-artful-2806
lp://qastaging/~ci-train-bot/mir/mir-ubuntu-zesty-2818
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yeah, this has always been a semi-obvious omission. I thought we had a bug already for this, but can't find it.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Although it might be a good thing to not tell apps/shells. If they render for the physical tri layout then you can't use any dynamic scaling to high DPI (which itself could utilize subpixel order information in a shader).

Daniel van Vugt (vanvugt)
summary: - Subpixel order not included in display information
+ Subpixel order not included in Mir display information
tags: added: xmir
Changed in xorg-server (Ubuntu):
importance: Undecided → Wishlist
Changed in mir:
status: New → Triaged
Changed in xorg-server (Ubuntu):
status: New → Triaged
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Bumped importance. This is significantly affecting the visual quality of text rendering in Unity8.

Changed in mir:
importance: Wishlist → Medium
Changed in xorg-server (Ubuntu):
importance: Wishlist → Medium
tags: added: visual-quality
Revision history for this message
Gerry Boland (gerboland) wrote :

Adding QtMir as from Qt5.5 and later, the QPA plugin can specify the subpixel hinting to Qt's font renderer (is part of QPlatformScreen implementation).

Changed in qtmir:
status: New → Triaged
importance: Undecided → Medium
Gerry Boland (gerboland)
Changed in qtubuntu:
status: New → Triaged
importance: Undecided → Medium
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: nobody → Chris Halse Rogers (raof)
milestone: none → 0.25.0
status: Triaged → In Progress
Changed in xorg-server (Ubuntu):
assignee: nobody → Daniel van Vugt (vanvugt)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Possibly related Unity8 issue: bug 1536751

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.25.0

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → In Progress
Mir CI Bot (mir-ci-bot)
Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → In Progress
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Is this half done or have we realistically done all we can do right now?

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Brandon Schaefer (brandontschaefer)
Changed in mir:
milestone: 0.25.0 → 0.26.0
Revision history for this message
Chris Halse Rogers (raof) wrote :

Not quite done - needs plumbing through nested platform, which needs nested platform migration onto non-deprecated display configuration.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Optionally we may also want the subpixel order information delivered in MirSurfaceOutputEvent.

Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.26.0 → 1.0.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This bug is a bit confused. Its implementation is now spread over multiple releases. I assume the above comments about it not being quite done yet are correct.

Revision history for this message
Gerry Boland (gerboland) wrote :

Just testing it now, AFAICS a nested server is not getting the correct subpixel data passed to it.

Revision history for this message
Gerry Boland (gerboland) wrote :

I've hacked qtmir to print the subpixel hint that Mir is supplying.

http://pastebin.ubuntu.com/24007971/ is my output. First I run a simple qml demo shell as nested server under USC, get "0" hint.

Then I run again as host server, get a hint "1 = RGB".

The "Subpixel hint" output of the 2 cases do not match for me, hence the complaint.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The subpixel information has never yet worked for me. My desktop reports "unknown" subpixel order for a pretty common monitor:

$ sudo mirout
...
Output 48: DisplayPort, connected, "DELL U2413", 1920x1200+0+0, enabled, on, 520mm x 320mm (24.0"), normal, 1.00x, unknown, monitor

"unknown" sounds like a bug. And that's without nesting.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Annoyingly it seems Linux doesn't know the subpixel order of my monitor (DRM_MODE_SUBPIXEL_UNKNOWN). And Google seems to suggest this is pretty common, because the information isn't available in EDIDs. So I can't easily test any fix for nested just yet.

What I can do however is look at support for /setting/ the subpixel order. Since it seems that's what most people will need to do. We may also want to consider defaulting to HRGB if it's unknown.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Gerry: OK, I can fake it, replicate your bug and then fix it. Done...

https://code.launchpad.net/~vanvugt/mir/nested-subpixel-arrangement/+merge/317586

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Hmm, that's interesting. Using integrated Intel graphics (DisplayPort) I get subpixel order "unknown" but if I use a radeon card (DVI) on the same monitor then it can detect "HRGB".

Michał Sawicz (saviq)
affects: qtubuntu → qtubuntu (Ubuntu)
Michał Sawicz (saviq)
affects: qtmir → qtmir (Ubuntu)
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 1.0.0

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed to lp:mir/0.26 at revision 4036, scheduled for release in Mir 0.26.2

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.26.2+17.04.20170322.1-0ubuntu1

---------------
mir (0.26.2+17.04.20170322.1-0ubuntu1) zesty; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.26.2 (https://launchpad.net/mir/+milestone/0.26.2)
    - Bugs fixed:
      . EDID does not change when hotplugging a monitor (LP: #1660017)
      . [regression] mirout crashes when connecting to unity8 or any nested
        server: [libprotobuf FATAL /usr/include/google/protobuf/repeated_field.
        h:1408] CHECK failed: (index) < (current_size_) (LP: #1661163)
      . Mir server crashed with SIGSEGV in
        mir::compositor::TemporaryBuffer::size() called from
        mir::gl::tessellate_renderable_into_rectangle() (LP: #1664760)
      . Nested servers (Unity8) periodically stutter (half frame rate) with
        Mir 0.26.1 (LP: #1666372)
      . Don't dereference the end iterator in ms::ApplicationSession::
        surface_after() (LP: #1667645)
      . [regression] OSK input shaping no longer works correctly (LP: #1669444)
      . Setting MirWindowSpec parameters always causes window's input_region
        to be reset (LP: #1670876)
      . Subpixel order not included in Mir display information (LP: #1393578)
      . Presentation chains should support various swap interval modes
        (LP: #1673533)
      . Need an extension for GBM buffers to replace
        mir_buffer_get_buffer_package() (LP: #1673534)
      . Seg fault on detect_fd_leaks (LP: #1661498)

 -- Cemil Azizoglu <email address hidden> Wed, 22 Mar 2017 04:54:19 +0000

Changed in mir (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

https://git.launchpad.net/~xmir-team/xorg-server/+git/xmir/commit/?id=9c303577325e8acb5c0585f3259eaf07cef92b3a

Changed in xorg-server (Ubuntu):
status: Triaged → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Daniel van Vugt (vanvugt)
Changed in xorg-server (Ubuntu):
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.