fd reception code is not exeception-safe when unexpected numbers of fds are received
Bug #1394362 reported by
Kevin DuBois
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Kevin DuBois | ||
mir (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
the easiest way to see this is to inspect mir::receive_data, or to run valgrind with track-fds = yes
In the wild, this would only leak 1-4 fd's per error. Given the type of errors that would cause this, it would take a lot of rare errors before we hit the process fd limit.
Related branches
lp://qastaging/~kdub/mir/fix-1394362
- Alberto Aguirre (community): Approve
- Alan Griffiths: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Alexandros Frantzis (community): Approve
-
Diff: 45 lines (+17/-5)1 file modifiedsrc/common/fd/fd_socket_transmission.cpp (+17/-5)
Changed in mir: | |
milestone: | none → 0.10.0 |
status: | New → In Progress |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.10.0