mir_connection_create_surface callback is sometimes called twice on error
Bug #1394873 reported by
Chris Halse Rogers
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Robert Carr | ||
mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
I've just run into some fun behaviour. In mir_surface.cpp, in the surface constructor, if:
server.
throws (such as if the RPC mechanism detects a connection break) then the created callback is called on the partially constructed MirSurface that's just about to be destructed. mir_connection_
This is likely to confuse API users :)
Related branches
lp://qastaging/~mir-team/mir/port-uncooperative-tests-to-surface-spec
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Alan Griffiths: Approve
- Cemil Azizoglu (community): Approve
-
Diff: 124 lines (+25/-27)3 files modifiedsrc/client/mir_surface.cpp (+21/-2)
src/client/rpc/mir_protobuf_rpc_channel.cpp (+0/-2)
tests/acceptance-tests/test_server_disconnect.cpp (+4/-23)
Changed in mir: | |
assignee: | nobody → Robert Carr (robertcarr) |
status: | New → In Progress |
milestone: | none → 0.10.0 |
Changed in mir: | |
status: | In Progress → Fix Committed |
importance: | Undecided → Medium |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
mir (0.10.0+ 15.04.20150107. 2-0ubuntu1) vivid; urgency=medium