Mir

Lots of Mir tests fail under memcheck

Bug #1524209 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Triaged
Medium
Unassigned
mir (Ubuntu)
Triaged
Medium
Unassigned

Bug Description

Lots of Mir tests fail under memcheck.

Although we use memcheck/valgrind as part of CI so this must be a simple mistake...

cmake .. -DENABLE_MEMCHECK_OPTION=ON
make
make test

80% tests passed, 5 tests failed out of 25

Total Test time (real) = 403.83 sec

The following tests FAILED:
   9 - mir_acceptance_tests (Failed)
  11 - mir_umock_acceptance_tests (Failed)
  13 - mir_integration_tests (Failed)
  19 - mir_unit_tests (Failed)
  23 - mir_unit_tests_mesa-x11 (Failed)
Errors while running CTest
Makefile:106: recipe for target 'test' failed

We might have to break this bug up...

Tags: testsfail

Related branches

lp://qastaging/~vanvugt/mir/workaround-1522031
PS Jenkins bot (community): Approve (continuous-integration)
Alberto Aguirre (community): Approve
Diff: 12 lines (+1/-1)
1 file modified
cmake/MirCommon.cmake (+1/-1)
lp://qastaging/~cemil-azizoglu/mir/xenial-touch-ci-failure
Daniel van Vugt: Abstain
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 33 lines (+26/-0)
1 file modified
tools/valgrind_suppressions_armhf (+26/-0)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The attached branch solves mir_acceptance_tests at least.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I should probably have mentioned I'm using xenial amd64.

Changed in mir:
assignee: nobody → Mir development team (mir-team)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 3189, scheduled for release in mir, milestone 0.19.0

Changed in mir:
status: New → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → New
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.19.0

Changed in mir:
status: New → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Triaged
importance: Undecided → High
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: Mir development team (mir-team) → nobody
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It's slightly better now:

92% tests passed, 3 tests failed out of 36

Total Test time (real) = 583.91 sec

The following tests FAILED:
  15 - mir_umock_acceptance_tests (Failed)
  17 - mir_integration_tests (Failed)
  32 - mir_unit_tests_mesa-x11 (Failed)
Errors while running CTest
Makefile:82: recipe for target 'test' failed
make: *** [test] Error 8

Are we failing to apply our suppressions?

Revision history for this message
Chris Halse Rogers (raof) wrote :

Works for me fine?

Changed in mir:
status: Triaged → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Still fails with the latest source from lp:mir, although the number of failures is shrinking...

94% tests passed, 2 tests failed out of 34

Total Test time (real) = 701.22 sec

The following tests FAILED:
  15 - mir_integration_tests (Failed)
  21 - mir_unit_tests (Failed)
Errors while running CTest
Makefile:93: recipe for target 'test' failed
make: *** [test] Error 8

Is the test setup in the Bug Description correct or is that missing out on some required suppressions?

Changed in mir:
status: Fix Released → Triaged
Daniel van Vugt (vanvugt)
Changed in mir:
importance: High → Medium
Revision history for this message
Michał Sawicz (saviq) wrote :

Syncing task from Mir.

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.