InputPlatformProbe.x11_platform_found_and_used_when_display_connection_works breaks with old input drivers present
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Alan Griffiths | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When there is a bump in the graphics platform ABI but no simultaneous bump in the input side we end up having more usable X11 platforms than expected. Because of the bump we get two x11 server modules:
$ ls lib/server-modules/
graphics-
graphics-
And as the log shows both are supported as input platforms (but only one would work as a graphics platform):
$ bin/mir_unit_tests --gtest_
MIR_CLIENT_
MIR_SERVER_
LD_LIBRARY_
exec=bin/
Running main() from main.cpp
Note: Google Test filter = InputPlatformProbe*
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from InputPlatformProbe
[ RUN ] InputPlatformPr
[2016-02-08 10:25:31.446023] mirserver: Selected input driver: mir:evdev-input (version: 0.20.0)
[ OK ] InputPlatformPr
[ RUN ] InputPlatformPr
[2016-02-08 10:25:31.460373] mirserver: Selected input driver: mir:x11-input (version: 0.20.0)
[2016-02-08 10:25:31.462505] mirserver: Selected input driver: x11-input (version: 0.19.0)
[2016-02-08 10:25:31.488286] mirserver: Selected input driver: mir:evdev-input (version: 0.20.0)
/home/alan/
Value of: platforms
Expected: has 2 elements and there exists some permutation of elements such that:
- element #0 is a or derived from a N3mir5input5evd
- element #1 is a or derived from a N3mir5input1X14
Actual: { 24-byte object <F0-8F 46-04 00-00 00-00 E0-8F 46-04 00-00 00-00 00-D4 43-04 00-00 00-00>, 24-byte object <60-94 46-04 00-00 00-00 50-94 46-04 00-00 00-00 80-DA 43-04 00-00 00-00>, 24-byte object <A0-D5 43-04 00-00 00-00 90-D5 43-04 00-00 00-00 50-DA 45-04 00-00 00-00> }, which has 3 elements
[ FAILED ] InputPlatformPr
[ RUN ] InputPlatformPr
[2016-02-08 10:25:31.524523] mirserver: Selected input driver: mir:evdev-input (version: 0.20.0)
[ OK ] InputPlatformPr
[ RUN ] InputPlatformPr
[2016-02-08 10:25:31.530326] mirserver: Selected input driver: mir:stub-input (version: 0.20.0)
[ OK ] InputPlatformPr
[----------] 4 tests from InputPlatformProbe (117 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (118 ms total)
[ PASSED ] 3 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] InputPlatformPr
1 FAILED TEST
If we have a release with a bump like this, users upgrading might end up in a problematic configuration.
Related branches
- Mir CI Bot: Approve (continuous-integration)
- Chris Halse Rogers: Approve
- Daniel van Vugt: Abstain
- Andreas Pokorny (community): Approve
- Cemil Azizoglu (community): Approve
-
Diff: 140 lines (+54/-36)3 files modifiedsrc/server/input/input_probe.cpp (+35/-36)
tests/unit-tests/CMakeLists.txt (+1/-0)
tests/unit-tests/input/test_input_platform_probing.cpp (+18/-0)
tags: | added: testsfail |
description: | updated |
Changed in mir: | |
status: | Incomplete → Confirmed |
description: | updated |
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in mir: | |
status: | Confirmed → In Progress |
Changed in mir: | |
milestone: | none → 0.21.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Workaround:
$ rm lib/server- modules/ server- mesa-x11. so.7