[regression] MIR_CLIENT_PERF_REPORT is missing window/surface names
Bug #1546933 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Daniel van Vugt | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[regression] MIR_CLIENT_
$ sudo env MIR_CLIENT_
Mir chose pixel format 3.
Using pixel format 4.
Current active output is 1920x1200 +0+0
Surface 0 DPI
Surface exposed
[1455787694.716178] perf: : 63.68 FPS, render time 389419.53ms, buffer lag 45.88ms (3 buffers)
[1455787695.717076] perf: : 60.00 FPS, render time 0.08ms, buffer lag 49.95ms (3 buffers)
[1455787696.717903] perf: : 60.00 FPS, render time 0.05ms, buffer lag 49.98ms (3 buffers)
^^^ The ": :" used to be ": window-name:"
Related branches
lp://qastaging/~vanvugt/mir/fix-1546933
Rejected
for merging
into
lp://qastaging/mir
- Chris Halse Rogers: Needs Fixing
- Mir CI Bot: Approve (continuous-integration)
- Alan Griffiths: Needs Fixing
- PS Jenkins bot (community): Approve (continuous-integration)
- Cemil Azizoglu (community): Approve
-
Diff: 155 lines (+85/-15)3 files modifiedsrc/client/mir_connection.cpp (+4/-1)
src/common/logging/dumb_console_logger.cpp (+18/-14)
tests/acceptance-tests/test_client_surfaces.cpp (+63/-0)
lp://qastaging/~vanvugt/mir/fix-1546933-2
- Mir CI Bot: Approve (continuous-integration)
- Chris Halse Rogers: Approve
- Alan Griffiths: Approve
-
Diff: 154 lines (+123/-1)3 files modifiedsrc/client/mir_connection.cpp (+4/-1)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_client_logging.cpp (+118/-0)
lp://qastaging/~mir-team/mir/fix-1546933-3
On hold
for merging
into
lp://qastaging/mir
- Mir development team: Pending requested
-
Diff: 221 lines (+132/-5)7 files modifiedinclude/common/mir/logging/logger.h (+1/-0)
src/client/default_connection_configuration.cpp (+2/-2)
src/client/mir_connection.cpp (+4/-1)
src/common/logging/logger.cpp (+2/-2)
src/common/symbols.map (+7/-0)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_client_logging.cpp (+115/-0)
tags: | added: regression |
Changed in mir: | |
assignee: | nobody → Daniel van Vugt (vanvugt) |
milestone: | none → 0.21.0 |
status: | Triaged → In Progress |
Changed in mir: | |
status: | Fix Committed → In Progress |
Changed in mir: | |
status: | In Progress → Fix Committed |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Bisected. The regression appeared in:
------- ------- ------- ------- ------- ------- ------- ------- ----
revno: 3240 [merge]
author: Kevin DuBois <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Thu 2016-01-14 01:50:25 +0000
message:
client: sort out the lifetime and ownership of MirSurface. The MirSurface lifetimes are now managed by MirConnection, and SurfaceMap is where MirConnection stores the surfaces.
Previously, they were imperfectly managed by SurfaceMap, eg, MirSurface would call "delete this" on itself. This led to scenarios where SurfaceMap wasn't really sure if the surface was alive or dead. Since NBS increases the amount of Events being sent to the surface, this would tease out existing problems with this scenario around surface destruction more.
Approved by Chris Halse Rogers, Alberto Aguirre, PS Jenkins bot, mir-ci-bot, Alan Griffiths. ------- ------- ------- ------- ------- ------- ------- ----
-------