HWC's vsync_signal_on is never called when using HWC 1.0
Bug #1613373 reported by
Ratchanan Srirattanamet
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Ratchanan Srirattanamet | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When using Mir with HWC 1.0, a HwcFbDevice is created. When HwcFbDevice's commit is called, it waits for a vsync to happen. But HWC configuration being created in this case is FbControl. As the result, HWC's vsync_signal_on is never called, causing vsync signals from HWC to never arrive. Later, when HwcFbDevice's commit is called, it'll stall waiting for a vsync forever.
Related branches
lp://qastaging/~peat-new/mir/use-hwc-blanking-control-with-hwc10
- Kevin DuBois (community): Approve
- Alan Griffiths: Approve
- Daniel van Vugt: Approve
-
Diff: 132 lines (+48/-5)4 files modifiedsrc/platforms/android/server/hal_component_factory.cpp (+4/-1)
src/platforms/android/server/hwc_blanking_control.cpp (+11/-2)
src/platforms/android/server/hwc_configuration.h (+2/-1)
tests/unit-tests/platforms/android/server/test_output_builder.cpp (+31/-1)
summary: |
- HWC's vsync_signal_on is never be called when using HWC 1.0 + HWC's vsync_signal_on is never called when using HWC 1.0 |
tags: | added: android |
Changed in mir: | |
assignee: | nobody → Ratchanan Srirattanamet (peat-new) |
milestone: | none → 0.25.0 |
status: | New → In Progress |
importance: | Undecided → Medium |
Changed in mir: | |
status: | In Progress → Fix Committed |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package mir - 0.25.0+ 17.04.20161203- 0ubuntu1
--------------- 17.04.20161203- 0ubuntu1) zesty; urgency=medium
mir (0.25.0+
* New upstream release 0.25.0 (https:/ /launchpad. net/mir/ +milestone/ 0.25.0) tEvent debug-extension -dev install debug/surface.h client_ multistream (LP: #1635273) resize_ * (LP: #1626924) :focus_ next_session (LP: #1625401)
- ABI summary:
. mirclient ABI unchanged at 9
. mirserver ABI bumped to 42
. mircommon ABI bumped to 7
. mirplatform ABI bumped to 14
. mirprotobuf ABI unchanged at 3
. mirplatformgraphics ABI bumped to 11
. mirclientplatform ABI unchanged at 5
. mirinputplatform ABI bumped to 6
. mircore ABI added, at version 1
- Enhancements:
. Added pointer confinement support
. Identify Raspberry Pi output types correctly
. Added dead key and compose key support
. Added gamma support for KMS hardware
. Added yakkety and zesty gcc-6 support
. Added surface passthrough support for fullscreen clients of nested
servers
. Introduced a new library `libmircore'
. Began migrating from Protobuf to Cap'n Proto starting with events
. Began support for VirtualBox (servers now start instead of crashing
but full support for GL clients is still missing)
. Began support for high precision frame timing, implemented for the
KMS, Android and X11 backends so far
. Added --display-report support for the X11 backend
. Improved reliability of `mirvanity' latency test tool
. Moved to using the CSS cursor naming scheme internally, although
the old symbolic indentifiers remain unchanged and still work
. Added refresh rate to MirSurfaceOutpu
. Many improvements to automated test quality and coverage
. Smoother desktop zoom using mir_proving_server (Super + two fingers)
- Bugs fixed:
. FTBFS On Zesty: invalid use of
'struct native_handle' (LP: #1638774)
. libmirclient-
twice (LP: #1639153)
. Mir crashes on virtual box drmModeCrtcSetGamma
Function not implemented (LP: #1638220)
. Flickering in mir_demo_
. Camera apps (camera & vanity) never exit (LP: #1635010)
. Clients cannot connect when MIR_SOCKET="" (LP: #1634508)
. mirtest-dev packaging fails to sepcify boost depends (LP: #1633537)
. cursor.h is unclear about mir_diagonal_
. Inconsistent underscores in cursor names (LP: #1632617)
. [regression] Accidental libmircommon.so.6 break (LP: #1617865)
. [regression] mir demo server fails to start with mx4 (LP: #1615703)
. [regression] Trust prompt now shown when starting camera (LP: #1612256)
. [regression] make abi-check fails to build (LP: #1626866)
. Nested servers prevent overlays or fullscreen bypass (LP: #1262116)
. Failed to get PRIME fd from gbm bo (LP: #1607812)
. Mir-on-X is difficult to use on 1366x768 laptop (LP: #1590959)
. Remove useless message 'Surface 0 DPI' in demos (LP: #1559831)
. Mir fails to cross-build with newer sbuild (LP: #1628507)
. Infinite loop in AbstractShell:
. Dest...