Mir

[regression] Accidental libmircommon.so.6 ABI break in Mir 0.24.0: mir::dispatch::ReadableFd* moved version stanzas

Bug #1617865 reported by Daniel van Vugt on 2016-08-29

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Mir	Fix Released	Medium	Daniel van Vugt	Mir 0.25.0
0.24	Fix Released	Medium	Daniel van Vugt	Mir 0.24.1
mir (Ubuntu)	Fix Released	Medium	Unassigned

Bug Description

Accidental libmircommon.so.6 ABI break in Mir 0.24: mir::dispatch::ReadableFd* moved version stanzas

So for example server-mesa-x11.so.9 can no longer load because it expects from libmircommon.so.6:
ZN3mir8dispatch10ReadableFdC1ENS_2FdERKSt8functionIFvvEE@MIR_COMMON_5.1
but actually in Mir 0.24.0 that got duplicated and changed to:
ZN3mir8dispatch10ReadableFdC1ENS_2FdERKSt8functionIFvvEE@MIR_COMMON_0.24

https://bugs.launchpad.net/mir/+bug/1611804/comments/8

Tags:

Related branches

lp://qastaging/~vanvugt/mir/common7

Merged into lp://qastaging/mir at revision 3758

Daniel van Vugt: Abstain on 2016-09-30

Mir CI Bot: Approve (continuous-integration) on 2016-09-28

Alan Griffiths: Disapprove on 2016-09-26

Kevin DuBois (community): Approve on 2016-09-12

lp://qastaging/~alan-griffiths/mir/fix-1617865

Rejected for merging into lp://qastaging/mir

Mir CI Bot: Approve (continuous-integration) on 2016-09-21

Alan Griffiths: Disapprove on 2016-09-20

Brandon Schaefer (community): Approve on 2016-09-19

lp://qastaging/~vanvugt/mir/fix-1617865-without-breaks

Merged into lp://qastaging/mir at revision 3716

Mir CI Bot: Approve (continuous-integration) on 2016-09-27

Kevin DuBois (community): Approve on 2016-09-26

Alan Griffiths: Approve on 2016-09-26

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-yakkety-2003 (Merged)

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-zesty-2180 (Merged)

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-zesty-2209

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-xenial-2736

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-yakkety-2783.1

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-yakkety-2783

Daniel van Vugt (vanvugt) on 2016-08-29

Changed in mir:
milestone:	none → 0.25.0

Daniel van Vugt (vanvugt) on 2016-08-29

Changed in mir:
assignee:	nobody → Daniel van Vugt (vanvugt)
status:	Triaged → In Progress

Daniel van Vugt (vanvugt) on 2016-08-29

Changed in mir:
importance:	High → Medium

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-08-29:

The problem originated in:

------------------------------------------------------------
revno: 3603 [merge]
author: Kevin DuBois <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Thu 2016-07-21 06:15:04 +0000
message:
update symbols to reflect the symbols actually captured in the 0.24 release.

Approved by Daniel van Vugt, mir-ci-bot.
------------------------------------------------------------

tags:	added: regression
summary:	- Accidental libmircommon.so.6 ABI break in Mir 0.24: + [regression] Accidental libmircommon.so.6 ABI break in Mir 0.24: mir::dispatch::ReadableFd* moved version stanzas

Alan Griffiths (alan-griffiths) on 2016-09-19

Changed in mir:
assignee:	Daniel van Vugt (vanvugt) → Alan Griffiths (alan-griffiths)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2016-09-21: Re: [regression] Accidental libmircommon.so.6 ABI break in Mir 0.24: mir::dispatch::ReadableFd* moved version stanzas

I'm giving up trying to fix this as I can't make anything nice work.

Changed in mir:
assignee:	Alan Griffiths (alan-griffiths) → nobody

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-09-22:

Given an assembler this would be simple to solve (if the offending code was also maintained in assembly). We're only fighting with the high level tools right now to make them do what we want.

I know it should be possible to fix this properly, in theory. But it's unclear if the standard tools will let us.

Changed in mir:
assignee:	nobody → Mir development team (mir-team)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2016-09-22:

libstdc++ has similar needs. One of the maintainers suggested looking in compatibility.cc - but didn't understand the magic, and I've tried what looks to be useful (and, at least, got visible aliases in the .o).

Daniel van Vugt (vanvugt) on 2016-09-26

Changed in mir:
assignee:	Mir development team (mir-team) → Daniel van Vugt (vanvugt)

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-09-27:

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.25.0

Changed in mir:
status:	In Progress → Fix Committed

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-09-27:

Fix committed to lp:mir/0.24 at revision 3633, scheduled for release in Mir 0.24.1

summary:	- [regression] Accidental libmircommon.so.6 ABI break in Mir 0.24: + [regression] Accidental libmircommon.so.6 ABI break in Mir 0.24.0: mir::dispatch::ReadableFd* moved version stanzas
Changed in mir (Ubuntu):
importance:	Undecided → Medium
status:	New → Triaged

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-10-12:

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.25.0

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-10-20:

This bug was fixed in the package mir - 0.24.1+16.10.20160928-0ubuntu1

---------------
mir (0.24.1+16.10.20160928-0ubuntu1) yakkety; urgency=medium

  * New upstream release 0.24.1 (https://launchpad.net/mir/+milestone/0.24.1)
    - ABI summary:
      . All ABI numbers remain unchanged.
      . mircommon ABI at 6, but now including a symbol misplaced in 0.24.0
    - Bugs fixed:
      . mirserver ignored further keymap configuration changes after a keyboard
        is configured (LP: #1626435)
      . fix for libmircommon.so.6 ABI break: version stanza of
        mir::dispatch::ReadableFd* moved to newer version (LP: #1617865)
      . clang builds fail (again) (LP: #1609612)
      . Valgrind errors in NesterServer.* cause subsequent tests
        (ServerDisconnect, ServerStartup, UnresponsiveClient) to fail
        (LP: #1612012)
      . Break potentially infinite loop in search for next session to focus
        (LP: #1625401)

-- Andreas Pokorny <email address hidden> Wed, 28 Sep 2016 12:09:49 +0000

Changed in mir (Ubuntu):
status:	Triaged → Fix Released

Daniel van Vugt (vanvugt) on 2016-12-19

Changed in mir:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.