MirAL

Missing miral::toolkit::WindowSpec::set_state()

Bug #1661256 reported by Daniel d'Andrada
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MirAL
Fix Released
Low
Alan Griffiths
MirAL 1.2

Bug Description

miral::toolkit::WindowSpec is missing a wrapper for mir_window_spec_set_state(MirWindowSpec* spec, MirWindowState state);

Related branches

lp://qastaging/~alan-griffiths/miral/fix-1661256
Alexandros Frantzis (community): Approve
Gerry Boland (community): Approve
Diff: 20 lines (+10/-0)
1 file modified
include/miral/toolkit/window_spec.h (+10/-0)
lp://qastaging/~alan-griffiths/miral/init-1.1
Gerry Boland: Pending requested
Diff: 566 lines (+434/-10)
6 files modified
debian/changelog (+10/-0)
debian/libmiral2.symbols (+9/-1)
miral/symbols.map (+39/-5)
miral/window_info.cpp (+21/-0)
miral/window_management_policy.cpp (+8/-0)
scripts/process_doxygen_xml.py (+347/-4)
lp://qastaging/~ci-train-bot/miral/miral-ubuntu-zesty-2476 (Merged)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

This is hardly a big deal - the following works fine:

    auto const spec = WindowSpec::for_normal_surface(connection, 50, 50, mir_pixel_format_argb_8888)
        .set_name(test_name);

    mir_window_spec_set_state(spec, mir_window_state_fullscreen);

Changed in miral:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Alan Griffiths (alan-griffiths)
milestone: none → 1.2
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Agreed. But we should have it for the sake of consistency.

Alan Griffiths (alan-griffiths)
Changed in miral:
status: In Progress → Fix Committed
Alan Griffiths (alan-griffiths)
Changed in miral:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.