Mistral does not always detect unreachable task with join

Bug #1636169 reported by Moshe Elisha
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Critical
Renat Akhmerov

Bug Description

The following workflow remains in RUNNING instead of changing to ERROR.

"task_b_1" fails and Mistral should know that "task_with_join" is now unreachable and should be changed from WAITING to ERROR.

---
version: "2.0"
test_join_wf:
  tasks:
    task_a_1:
      action: std.noop
      on-success:
        - task_with_join

    task_b_1:
      action: std.http
      input:
        url: "http://1.1.1.1"
      on-success:
        - task_b_2

    task_b_2:
      action: std.noop
      on-success:
        - task_b_3

    task_b_3:
      action: std.noop
      on-success:
        - task_with_join

    task_with_join:
      action: std.noop
      join: all

CLI output:

[15:02 cbnd@cbnd-785-application ~] > mistral execution-create test_join_wf
+-------------------+--------------------------------------+
| Field | Value |
+-------------------+--------------------------------------+
| ID | 17849d1c-c684-417a-8cd8-bcd9e97ab009 |
| Workflow ID | 40f1e26a-4f55-44d1-932e-ede437fed7ef |
| Workflow name | test_join_wf |
| Description | |
| Task Execution ID | <none> |
| State | RUNNING |
| State info | None |
| Created at | 2016-10-24 12:02:08.615491 |
| Updated at | 2016-10-24 12:02:08.619341 |
+-------------------+--------------------------------------+
[15:02 cbnd@cbnd-785-application ~] > mistral task-list 17849d1c-c684-417a-8cd8-bcd9e97ab009
+--------------------------------------+----------------+---------------+--------------------------------------+---------+------------------+
| ID | Name | Workflow name | Execution ID | State | State info |
+--------------------------------------+----------------+---------------+--------------------------------------+---------+------------------+
| 44ff5e2f-eb1e-4d36-8eb2-af8d3db134dd | task_with_join | test_join_wf | 17849d1c-c684-417a-8cd8-bcd9e97ab009 | WAITING | Task is waiting. |
| 7b79267e-c556-4fb0-b887-a73a07b9e977 | task_b_1 | test_join_wf | 17849d1c-c684-417a-8cd8-bcd9e97ab009 | RUNNING | None |
| ee8d64ee-470d-4710-9a0a-a3823bc86d8f | task_a_1 | test_join_wf | 17849d1c-c684-417a-8cd8-bcd9e97ab009 | SUCCESS | None |
+--------------------------------------+----------------+---------------+--------------------------------------+---------+------------------+
[15:02 cbnd@cbnd-785-application ~] > mistral task-list 17849d1c-c684-417a-8cd8-bcd9e97ab009
+--------------------------------------+----------------+---------------+--------------------------------------+---------+------------------------------+
| ID | Name | Workflow name | Execution ID | State | State info |
+--------------------------------------+----------------+---------------+--------------------------------------+---------+------------------------------+
| 44ff5e2f-eb1e-4d36-8eb2-af8d3db134dd | task_with_join | test_join_wf | 17849d1c-c684-417a-8cd8-bcd9e97ab009 | WAITING | Task is waiting. |
| 7b79267e-c556-4fb0-b887-a73a07b9e977 | task_b_1 | test_join_wf | 17849d1c-c684-417a-8cd8-bcd9e97ab009 | ERROR | Failed to run action [act... |
| ee8d64ee-470d-4710-9a0a-a3823bc86d8f | task_a_1 | test_join_wf | 17849d1c-c684-417a-8cd8-bcd9e97ab009 | SUCCESS | None |
+--------------------------------------+----------------+---------------+--------------------------------------+---------+------------------------------+
[15:11 cbnd@cbnd-785-application ~] > mistral execution-get 17849d1c-c684-417a-8cd8-bcd9e97ab009
+-------------------+--------------------------------------+
| Field | Value |
+-------------------+--------------------------------------+
| ID | 17849d1c-c684-417a-8cd8-bcd9e97ab009 |
| Workflow ID | 40f1e26a-4f55-44d1-932e-ede437fed7ef |
| Workflow name | test_join_wf |
| Description | |
| Task Execution ID | <none> |
| State | RUNNING |
| State info | None |
| Created at | 2016-10-24 12:02:08 |
| Updated at | 2016-10-24 12:02:08 |
+-------------------+--------------------------------------+

Changed in mistral:
milestone: none → ocata-1
assignee: nobody → Renat Akhmerov (rakhmerov)
importance: Undecided → Critical
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/390390

Changed in mistral:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/390390
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=78514f8bf5d4ef3e6cb4315ad0ed8700818b8d1a
Submitter: Jenkins
Branch: master

commit 78514f8bf5d4ef3e6cb4315ad0ed8700818b8d1a
Author: Renat Akhmerov <email address hidden>
Date: Mon Oct 24 21:11:12 2016 +0200

    Fix a bug in the algo that determines if a route is possible

    Change-Id: I0747c35d07bac85feded4ff41a59d1551a0f7652
    Closes-Bug: #1636169

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/391802

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/392046

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on mistral (stable/newton)

Change abandoned by Renat Akhmerov (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/391802
Reason: It's not a direct cherry pick of a patch from master.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/newton)

Reviewed: https://review.openstack.org/392046
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=f49be145b1107611e5f7d8ba948f158bb6c057c0
Submitter: Jenkins
Branch: stable/newton

commit f49be145b1107611e5f7d8ba948f158bb6c057c0
Author: Renat Akhmerov <email address hidden>
Date: Mon Oct 24 19:11:12 2016 +0000

    Fix a bug in the algo that determines if a route is possible

    Closes-Bug: #1636169
    (cherry picked from commit 78514f8)
    Change-Id: I0747c35d07bac85feded4ff41a59d1551a0f7652

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/395984

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/395986

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on mistral (stable/newton)

Change abandoned by Noa Koffman (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/395986

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/newton)

Reviewed: https://review.openstack.org/395984
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=1a7988d95721b7d99efb362574901a7dc6080354
Submitter: Jenkins
Branch: stable/newton

commit 1a7988d95721b7d99efb362574901a7dc6080354
Author: Renat Akhmerov <email address hidden>
Date: Mon Oct 24 19:11:12 2016 +0000

    Fix a bug in the algo that determines if a route is possible
    Closes-Bug: #1636169

    Change-Id: I1e590023db45637c2e54b08172e2d99551119dae

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 4.0.0.0b1

This issue was fixed in the openstack/mistral 4.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.