Abstract the context in mistral-lib

Bug #1673017 reported by Dougal Matthews
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Dougal Matthews

Bug Description

At the moment we pass an internal object from mistral to mistral-lib. We should provide some sort of abstraction and documentation of this object. This would allow us to change it in Mistral as we need - because it is internal and still provide a stable interface with mistral-lib.

Full details:

This bug is based on the comments on https://review.openstack.org/#/c/411412/12/mistral_lib/actions/base.py

Renat: I think it'd be cool to have a class Context (or ActionContext) with well defined and documented structure residing in mistral-lib too. And this doc could have a reference to this class so that users could go and easily see what's available in the context.

Dougal: +1, this would also be useful for testing as I could make a fake context using the class in mistral-lib. It would also allow us to change the context in Mistral (as it is internal) and only need to update the class in mistral-lib that abstracts it. Currently we expose an internal object.

Changed in mistral:
milestone: pike-1 → pike-2
Changed in mistral:
milestone: pike-2 → pike-3
Changed in mistral:
milestone: pike-3 → pike-rc1
Changed in mistral:
milestone: pike-rc1 → queens-1
Revision history for this message
Renat Akhmerov (rakhmerov) wrote :

@Dougal, can we close it?

Changed in mistral:
milestone: queens-1 → queens-2
Changed in mistral:
milestone: queens-2 → queens-3
Revision history for this message
Dougal Matthews (d0ugal) wrote :

We are waiting for a queens release so that this patch can land: https://review.openstack.org/506185

Then this bug can be closed.

Changed in mistral:
milestone: queens-3 → rocky-1
Dougal Matthews (d0ugal)
Changed in mistral:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.