Validate "verify" parameter of std.http action

Bug #1717354 reported by Renat Akhmerov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
Yuval Adar

Bug Description

If "verify" parameter doesn't point to an existing file (certificate) then std.http action fails with this failure:

2017-09-12 02:40:58.713 18428 ERROR mistral.executors.default_executor File "/usr/lib/python2.7/site-packages/mistral/actions/std_actions.py", line 194, in run
2017-09-12 02:40:58.713 18428 ERROR mistral.executors.default_executor raise exc.ActionException("Failed to send HTTP request: %s" % e)
2017-09-12 02:40:58.713 18428 ERROR mistral.executors.default_executor ActionException: Failed to send HTTP request: __str__ returned non-string (type Error)
2017-09-12 02:40:58.713 18428 ERROR mistral.executors.default_executor

The error message is confusing.

We can check if the url parameter has https protocol then we could validate "verify" parameter value to prevent that (we also need to keep in mind that it can be just True/False). In case of regular http then we should skip validation.

Changed in mistral:
milestone: none → queens-1
importance: Undecided → Medium
status: New → Confirmed
Changed in mistral:
milestone: queens-1 → queens-2
Changed in mistral:
milestone: queens-2 → queens-3
Changed in mistral:
milestone: queens-3 → rocky-1
Dougal Matthews (d0ugal)
Changed in mistral:
milestone: rocky-1 → rocky-2
status: Confirmed → Triaged
Dougal Matthews (d0ugal)
Changed in mistral:
milestone: rocky-2 → none
Yuval Adar (yadar)
Changed in mistral:
assignee: nobody → Yuval Adar (yadar)
Changed in mistral:
status: Triaged → In Progress
Dougal Matthews (d0ugal)
Changed in mistral:
milestone: none → rocky-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/579777
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=5cfaa9ca06779021b3d4ee6c94358c1d1e3a9a08
Submitter: Zuul
Branch: master

commit 5cfaa9ca06779021b3d4ee6c94358c1d1e3a9a08
Author: Yuval Adar <email address hidden>
Date: Tue Jul 3 09:38:30 2018 +0300

    detect https and act accordingly

    Use six for url parsing

    Closes-Bug: 1717354
    Change-Id: Id6a08cf01f4bbc341e1488bebbdc175d86c27d54

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 7.0.0.0b3

This issue was fixed in the openstack/mistral 7.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.