mistral-db-manage discards rev-id parameter

Bug #1782127 reported by Hardik Jasani
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Hardik Jasani

Bug Description

mistral-db-manage is wrapper script for DB migrations framework (alembic) in mistral.

alembic accepts parameter `--rev-id` to override auto-generated revision id.
As we use alpha-numeric sequence of 001, 002, 003..., in script names, usage of this parameter is required.

Presently, mistral-db-manage doesn't handle this parameter correctly, and throws an error.

$ mistral-db-manage revision -m "add namespace column to workbooks actions" --rev-id "029"
usage: mistral-db-manage [-h] [--config-dir DIR] [--config-file PATH]
                         [--debug] [--log-config-append PATH]
                         [--log-date-format DATE_FORMAT] [--log-dir LOG_DIR]
                         [--log-file PATH] [--nodebug] [--nouse-debugger]
                         [--nouse-journal] [--nouse-json] [--nouse-syslog]
                         [--openstack_actions_mapping_path MAPPING_PATH]
                         [--server SERVER]
                         [--syslog-log-facility SYSLOG_LOG_FACILITY]
                         [--use-debugger] [--use-journal] [--use-json]
                         [--use-syslog] [--watch-log-file]
mistral-db-manage: error: unrecognized arguments: --rev-id 029

Hardik Jasani (hjasani)
Changed in mistral:
assignee: nobody → Hardik Jasani (hjasani)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/583214

Changed in mistral:
milestone: none → rocky-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/583214
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=03fbd83cd9492bd0333b2924a658475d7bd5d13e
Submitter: Zuul
Branch: master

commit 03fbd83cd9492bd0333b2924a658475d7bd5d13e
Author: hardikj <email address hidden>
Date: Tue Jul 17 17:13:56 2018 +0530

    Fix rev-id parameter in mistral-db-manage

    Accept '--rev-id' parameter, and forward it to alembic revision
    command internally.

    Change-Id: Ib4d5a056eba792f468868b12ab011f71999713a2
    Closes-Bug: #1782127

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral

This issue was fixed in the openstack/mistral development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.