New CentOS7 tids.service does not use the RHEL6 sysconfig files

Bug #1598856 reported by Stefan Paetow
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Moonshot Trust-Router
Triaged
Low
Jennifer Richards

Bug Description

The new RHEL/CentOS 7 tids.service file does not use the existing RedHat/CentOS 6 files for the TIDS service. This causes an eventual failure:

1. It should read /etc/sysconfig/tids, not /etc/default/tids (the Debian location)
2. ExecStart should use: /usr/bin/tids ${TIDS_SERVER_IP} ${TIDS_GSS_NAME} ${TIDS_SERVER_NAME} (currently it uses the Debian-style "${ipaddr} ${gssname} ${hostname}" command-line)

Should we tweak the packages to fix this to RHEL 6 style or shall we break with convention to match Debian and RHEL 7 up?

Revision history for this message
Adam Bishop (adam-omega) wrote :

/etc/sysconfig and /etc/default are kind of legacy.

As a quick fix, the unit file should read /etc/sysconfig/tids as an EnvironmentFile.

As a proper fix, tids should:
* look for an activated socket and use it
* look for a config file and load it (optional)
* if not overridden by config, use the system fqdn as the GSS name and listen on all addresses[1]

[1] turns out we don't actually use the IP specified on the command line - it's passed through to tids_listen() but:

  108: saddr->sin_addr.s_addr = INADDR_ANY;

Revision history for this message
Stefan Paetow (stefan-paetow) wrote :

The EnvironmentFile parameter should at the very least be fixed, yes.

The 'gssname' is the name used for the trust router, i.e. <email address hidden>, so it's still a parameter you have to specify somewhere. As for the IP address, yes, any non-required parameters should go.

Margaret Cullen (mrw42)
Changed in moonshot-tr:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Jennifer Richards (jennifer-k)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.