mosquitto

static analysis reports missing lock in mqtt3_handle_connect()

Bug #1354613 reported by Mark Culley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mosquitto
New
Undecided
Unassigned

Bug Description

The line in question is ...

db->contexts[i]->last_msg_in = mosquitto_time();

in mqtt3_handle_connect(). Static analysis points out that in all other instance where last_msg_in is referenced, a lock is requested first:

pthread_mutex_lock(&mosq->msgtime_mutex);

It is not clear to me that mqtt3_handle_connect() needs to request a lock, but that is for mosquitto to decide.

Revision history for this message
Roger Light (roger.light) wrote :

Hi there,

I'm migrating bugs to Eclipse. The new url for this bug is:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=452917

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.