Murano

[dashboard] murano-dashboard uses outdated eslint and eslint-config-openstack

Bug #1524552 reported by Kirill Zaitsev
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Low
Darla Ahlert
Murano mitaka-3 "m3"

Bug Description

We have "devDependencies": {
    "eslint": "^0.23.0",
    "eslint-config-openstack": "1.2.0"
  }

while horizon has switched to more recent and stable options of

    "eslint": "1.2.1",
    "eslint-config-openstack": "1.2.3",

We should also adopt this change and fix any jslint errors, that might arise from switching up

Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: none → mitaka-2
Darla Ahlert (da741q)
Changed in murano:
assignee: nobody → Darla Ahlert (da741q)
Darla Ahlert (da741q)
Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/264837

Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

Hi. the patch you submitted is not enough. As mentioned in the bug's description you also have to "fix any jslint errors, that might arise from switching up". The new config became stricter, so we should alter our code to be compliant with new rules

Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: mitaka-2 → mitaka-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/264837
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=28b49ebef29dac81da27c6637abfe7d60a771a28
Submitter: Jenkins
Branch: master

commit 28b49ebef29dac81da27c6637abfe7d60a771a28
Author: Darla Ahlert <email address hidden>
Date: Thu Jan 7 09:33:07 2016 -0600

    Update eslint devDependencies in Murano dashboard

    Currently, murano-dashboard has
    "devDependencies": {
        "eslint": "^0.23.0",
        "eslint-config-openstack": "1.2.0"
      }
    while horizon has switched to more recent and stable options of:
        "eslint": "1.2.1",
        "eslint-config-openstack": "1.2.3"

    This updates the devDependencies in Murano dashboard to
    mirror those of horizon.

    Change-Id: I56b93cfba2d69319ca4d4a5f1b5983009b302168
    Closes-Bug: #1524552

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano-dashboard 2.0.0.0b3

This issue was fixed in the openstack/murano-dashboard 2.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.