Murano

[dashboard] setting confirmInput to false doesn't work

Bug #1540867 reported by Kirill Zaitsev
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Jacek Tomasiak
Murano mitaka-3 "m3"

Bug Description

https://www.dropbox.com/s/juhusxvmuhpgwfh/Screenshot%202016-02-02%2014.12.19.png?dl=0

Seems that there is still a check for password equality even though the 2d field is not shown

Jacek Tomasiak (skazi)
Changed in murano:
assignee: nobody → Jacek Tomasiak (skazi)
Revision history for this message
Jacek Tomasiak (skazi) wrote :

Hi,

Could you please share the application definition you are using?

Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

Hi Jacek!

I'm using an empty app with the following ui.yaml:

Version: 2

Application:
  ?:
    type: io.murano.empty.Empty
  name: $.appConfiguration.name

Forms:
  - appConfiguration:
      fields:
        - name: name
          type: string
          label: label
          initial: "string"
        - name: password
          type: password
          label: password
          confirmInput: false

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/278039

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/278039
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=ec9364b8c3a6aa0fd5a9ade81a20c8fb594d6d40
Submitter: Jenkins
Branch: master

commit ec9364b8c3a6aa0fd5a9ade81a20c8fb594d6d40
Author: Jacek Tomasiak <email address hidden>
Date: Tue Feb 9 19:55:27 2016 +0100

    Fix validation of password fields form with confirmInput=false

    Application deployment forms which contain "password" type fields with
    confirmInput set to false don't show the second input for password
    confirmation but during form validation expect both inputs to contain
    the same value.

    With this change the copy of password is not checked if confirmInput
    is set to false.

    Change-Id: I2353e2497f9c66dd9d9c0d543792a80bf1ae2a1b
    Closes-Bug: #1540867

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano-dashboard 2.0.0.0b3

This issue was fixed in the openstack/murano-dashboard 2.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.