2 * poor choice of variable type ?
Bug #1236500 reported by
dcb
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Musca |
New
|
Undecided
|
Unassigned | ||
Bug Description
I just ran the static analyser "cppcheck" over
the source code of musca-0.9.24
It said
[tools.c:231]: (warning) Storing fgetc() return value in char variable and then comparing with EOF.
[musca.c:3437]: (warning) Storing getchar() return value in char variable and then comparing with EOF.
According to page 16 of K&R 2, variables must be type int to
compare successfully with EOF.
Suggest code rework.
Revision history for this message
| Jeroen Roovers (jer-gentoo) wrote | #1 |
Revision history for this message
| Jeroen Roovers (jer-gentoo) wrote | #2 |
To post a comment you must log in.
The previous patch didn't address the original issue.