NetworkManager

nm-applet GUI allows invalid PPTP configuration

Bug #438834 reported by fubarbundy on 2009-09-29

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	NetworkManager	Fix Released	Medium	gnome-bugs #596762
	network-manager-pptp (Ubuntu)	Fix Released	Low	Unassigned	Ubuntu karmic-updates
Nominated for Karmic by Mathieu Trudel-Lapierre

Bug Description

Binary package hint: network-manager

Ubuntu version: Karmic Alpha 64-bit with updates to 2009/09/28
Network Manager version: 0.8~a~git.20090923t064445.b20cef2-0ubuntu1

According to http://technet.microsoft.com/en-us/library/cc732393%28WS.10%29.aspx MPPE is not supported with PAP or CHAP authentication. However, when creating or editing a PPTP VPN connection in nm-applet, the Advanced Options window allows 'Use Point-to-Point Encryption (MPPE)' to be ticked even when only PAP and/or CHAP are selected as authentication methods.

The VPN connection then fails, with the following /var/log/syslog message:

MPPE required, but MS-CHAP[v2] auth not performed.

(which makes sense)

Related branches

lp://qastaging/~cyphermox/network-manager/lp438834-mppe-methods-combo

Merged into lp://qastaging/~network-manager/network-manager/pptp-ubuntu.head

Alexander Sack: Approve on 2009-10-23

lp://qastaging/ubuntu/lucid/network-manager-pptp

Revision history for this message

Alexander Sack (asac) wrote on 2009-09-29:

assigning to mat for now. probably should be discussed with dcbw and a patch suggested based on that.

Changed in network-manager (Ubuntu):
assignee:	nobody → Matt Trudel (mathieu-tl)
importance:	Undecided → Low
status:	New → Triaged

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2009-10-15:

This looks to me like a bug in network-manager-pptp rather than the backend. Re-filing against it instead.

affects:

network-manager (Ubuntu) → network-manager-pptp (Ubuntu)

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2009-10-15:

lp438834_mppe_is_for_mschap_only.patch Edit (6.7 KiB, text/plain)

Attaching the initial patch I brought up on the upstream bug, this is still awaiting review from dcbw, but in case someone wants to apply it, it definitely seems to work.

Revision history for this message

Alexander Sack (asac) wrote on 2009-10-16:

did you approach dan about this patch already?

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2009-10-20:

Yes, I did, still working on it, there is an updated version of the patch in the Gnome tracker..

Mathieu Trudel-Lapierre (cyphermox) on 2009-10-23

Changed in network-manager-pptp (Ubuntu):
status:	Triaged → Fix Committed
status:	Fix Committed → In Progress

Mathieu Trudel-Lapierre (cyphermox) on 2009-10-23

Changed in network-manager-pptp (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2009-10-23:

We should ship this as an SRU, as per discussion on #nm; setting karmic-updates as milestone target.

Changed in network-manager-pptp (Ubuntu):
milestone:	none → karmic-updates
assignee:	Matt Trudel (mathieu-tl) → nobody

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-01-26:

This bug was fixed in the package network-manager-pptp - 0.8~rc1-0ubuntu1

---------------
network-manager-pptp (0.8~rc1-0ubuntu1) lucid; urgency=low

  * upstream release tagged 0.7.997 (NM 0.8~rc1)
    + 0.7.997
    - core: resolve pptp gateway hostname
    - properties: fix MPPE EAP method combinations (LP: #438834)
  * Add logic to map ~rc1 to 0.7.997 tag, as per the main NM branch.
  * Bump build-deps to require NM 0.8~rc1.
  * Update Standards-Version to 3.8.3.
-- Mathieu Trudel <email address hidden> Tue, 22 Dec 2009 14:16:41 -0500