networking-vsphere

Fix security_groups_provider_updated method in stable/kilo branch

Bug #1488817 reported by Romil Gupta
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-vsphere
Fix Committed
Undecided
Romil Gupta

Bug Description

2015-08-26 07:17:13.479 ERROR oslo_messaging.rpc.dispatcher [req-cadca9c4-a847-4e1a-b3da-547c88ae7503 None None] Exception during message handling: security_groups_provider_updated() takes exactly 2 arguments (1 given)
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher Traceback (most recent call last):
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 142, in _dispatch_and_reply
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher executor_callback))
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 186, in _dispatch
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher executor_callback)
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 130, in _do_dispatch
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher result = func(ctxt, **new_args)
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/neutron/neutron/agent/securitygroups_rpc.py", line 160, in security_groups_provider_updated
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher self.sg_agent.security_groups_provider_updated()
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher TypeError: security_groups_provider_updated() takes exactly 2 arguments (1 given)
2015-08-26 07:17:13.479 7478 TRACE oslo_messaging.rpc.dispatcher

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-vsphere (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/217023

Romil Gupta (romilg)
Changed in networking-vsphere:
assignee: nobody → Romil Gupta (romilg)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-vsphere (stable/kilo)

Reviewed: https://review.openstack.org/217023
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=68d1568d310362bd4025d728fd65d6b98d753709
Submitter: Jenkins
Branch: stable/kilo

commit 68d1568d310362bd4025d728fd65d6b98d753709
Author: Romil Gupta <email address hidden>
Date: Wed Aug 26 01:10:50 2015 -0700

    Fix security_groups_provider_updated rpc in ovsvapp_sg_agent.py

    This fix is only for stable/kilo branch.

    Reason:
    The base class SecurityGroupAgentRpc(object):
       def security_groups_provider_updated(self)
    method doesn't expect any arguments to be passed.
    https://github.com/openstack/neutron/blob/stable/kilo/neutron/agent/securitygroups_rpc.py#L284

    Hence, we need to fix this in ovsvapp_sg_agent.py since we are overriding this
    RPC and introducing new RPC named 'enhanced_sg_provider_updated'L35.

    Closes-Bug: #1488817

    Change-Id: Ice45c2092e5d2375c6c44ed039fc7c9333e1fa41

tags: added: in-stable-kilo
Vivekanandan Narasimhan (vivekanandan-narasimhan)
Changed in networking-vsphere:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.