[RFE] Strict minimum bandwidth support (egress)

I'm assuming here I can toggle it, even this is going to be a long term effort, and we need to start by a spec to make some design decisions.

We may want to create a blueprint and spec for this to go into the detail, since this is a multi-cycle, nova-integration effort and we need to put several bricks in place to build it.

Related fix proposed to branch: master
Review: https://review.openstack.org/396297

Related fix proposed to branch: master
Review: https://review.openstack.org/402121

Related fix proposed to branch: master
Review: https://review.openstack.org/404343

Fix proposed to branch: master
Review: https://review.openstack.org/404647

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.openstack.org/404647
Reason: Merged in https://review.openstack.org/#/c/401254/

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/404343
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/404343
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/402121
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Reviewed: https://review.openstack.org/396297
Committed: https://git.openstack.org/cgit/openstack/neutron-specs/commit/?id=28c17a56437cfa7e6c792160334406e6464d76e1
Submitter: Jenkins
Branch: master

commit 28c17a56437cfa7e6c792160334406e6464d76e1
Author: Miguel Angel Ajo <email address hidden>
Date: Thu Nov 10 16:20:04 2016 +0100

    Add a spec for strict minimum bandwidth support

    Integration to the nova placement API will allow us to
    provide guaranteed minimum bandwidth for ports.

    Change-Id: Iecdf70f3090910a4faabf077627cc2f973bfb5b6
    Related-Bug: #1578989
    Blueprint: strict-minimum-bandwidth-support

Related fix proposed to branch: master
Review: https://review.openstack.org/508149

Fix proposed to branch: master
Review: https://review.openstack.org/511510

Fix proposed to branch: master
Review: https://review.openstack.org/511774

Fix proposed to branch: master
Review: https://review.openstack.org/511936

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.openstack.org/511510
Reason: Superseded by https://review.openstack.org/#/c/511936/

Fix proposed to branch: master
Review: https://review.openstack.org/512396

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.openstack.org/511774
Reason: Superseded by https://review.openstack.org/#/c/512396/

Fix proposed to branch: master
Review: https://review.openstack.org/512674

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.openstack.org/512674
Reason: This patch will be merged with https://review.openstack.org/#/c/512396/

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.openstack.org/401254

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.openstack.org/508149
Reason: Nova spec not approved

We will continue this in Rocky, when we have the required placement API functionality

Reviewed: https://review.openstack.org/511936
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=9ef0860033796ce38c29e9b541898b42fbb913c5
Submitter: Zuul
Branch: master

commit 9ef0860033796ce38c29e9b541898b42fbb913c5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Oct 13 18:47:55 2017 +0100

    Rehome placement client to neutron-lib

    The placement client is going to be used by other services aside from
    segments; e.g. QoS plugin. It makes sense to move this file to a common
    place, like neutron-lib.

    Closes-Bug: #1723452
    Partial-Bug: #1578989

    Change-Id: I2f7d204828a620152ec9e005e057fc7fd77f9126

Reviewed: https://review.openstack.org/512396
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=874cf4f550e9c10c8b03af6d735642bc61a589e6
Submitter: Zuul
Branch: master

commit 874cf4f550e9c10c8b03af6d735642bc61a589e6
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Oct 16 20:24:55 2017 +0100

    Add new Resource Provider functions to placement client

    Added list_resource_providers function, which allows to retrieve
    a list of Resource Providers filtering by UUID or parent UUID.

    Added get_resource_provider function, which allows to retrieve an
    specific Resource Provider by its UUID.

    This feature depends on Nova Nested Resource Providers.

    Depends-On: I4db74e4dc682bc03df6ec94cd1c3a5f5dc927a7bi

    Change-Id: I6eb42b9a53c8001c5f14d4d1c9a98e060148ae21
    Partial-Bug: #1578989
    Co-Authored-By: Slawek Kaplonski <email address hidden>

Related fix proposed to branch: master
Review: https://review.openstack.org/552938

Related fix proposed to branch: master
Review: https://review.openstack.org/554532

Reviewed: https://review.openstack.org/554532
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=f0a9959a7fd98b091a17a29544eacdbd6dd37337
Submitter: Zuul
Branch: master

commit f0a9959a7fd98b091a17a29544eacdbd6dd37337
Author: Lajos Katona <email address hidden>
Date: Tue Mar 20 14:00:29 2018 +0100

    Fix placement calls in placement client

    Based on the placement api-ref fix the already implemented placement API
    calls in the placement client of neutron-lib.

    Fixed/changed parts:
    - Add version header to create_resource_provider
    - Change create_inventory to update_resource_provider_inventories, as
    the http request is a PUT not a POST, and add exception to handle the
    case when the rp is not found.
    - Change update_inventory to update_resource_provider_inventory, to make
    the method name in sync with placement API ref.
    - Fix the failing unit tests, and cover the negative case for
    update_resource_provider_inventories.

    Change-Id: I336c57e734f91795038c5ba9074970d1f5522da2
    Related-Bug: #1578989

Reviewed: https://review.openstack.org/552938
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=a24bf9841d1c3717c0f38778c0c63acd7028dbcd
Submitter: Zuul
Branch: master

commit a24bf9841d1c3717c0f38778c0c63acd7028dbcd
Author: Lajos Katona <email address hidden>
Date: Tue Mar 20 14:22:15 2018 +0100

    Add placement calls for bandwith resource provider

    Add placement calls that are necessary to report the necessary resource
    providers, traits, resource classes and inventories for bandwidth
    allocation in placement.

    Related-Bug: #1578989
    Change-Id: Ie3a14e5461d2d14ee77e1bd101943b7c28cf86f1

Related fix proposed to branch: master
Review: https://review.openstack.org/566047

Reviewed: https://review.openstack.org/508149
Committed: https://git.openstack.org/cgit/openstack/neutron-specs/commit/?id=dca619fd9e581a1863073460cde5b4d34db9dfa0
Submitter: Zuul
Branch: master

commit dca619fd9e581a1863073460cde5b4d34db9dfa0
Author: Bence Romsics <email address hidden>
Date: Wed May 9 13:53:58 2018 +0200

    QoS minimum bandwidth allocation in Placement API

    This spec describes how to model, from Neutron, a new resource provider
    in the Placement API to describe the bandwidth allocation.

    Based on a Rocky PTG discussion this is a re-work of the spec.

    Co-Authored-By: Rodolfo Alonso Hernandez <email address hidden>
    Co-Authored-By: Bence Romsics <email address hidden>
    Co-Authored-By: Balazs Gibizer <email address hidden>

    Related-Bug: #1578989
    Change-Id: Ib995837f6161bcceb09735a5601d8b79a25a7354
    See-Also: Ie7be551f4f03957ade9beb64457736f400560486

Reviewed: https://review.openstack.org/566047
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=2b5d1fdd1f68a5231e57b8c55abfc84c9a6a48a0
Submitter: Zuul
Branch: master

commit 2b5d1fdd1f68a5231e57b8c55abfc84c9a6a48a0
Author: Lajos Katona <email address hidden>
Date: Wed May 2 16:30:26 2018 +0200

    Fix list_resource_providers filters

    list_resource_providers failed filtering as the filter parameters like
    name, or in_tree must be added to the url as query strings:
    /resource_providers?name=foo&in_tree=<uuid>

    Related-Bug: #1578989
    Change-Id: I794972e93dbcf7310154cc1cceef25b9df618450

Fix proposed to branch: master
Review: https://review.openstack.org/574781

Fix proposed to branch: master
Review: https://review.openstack.org/574783

Fix proposed to branch: master
Review: https://review.openstack.org/577220

Fix proposed to branch: master
Review: https://review.openstack.org/577223

Fix proposed to branch: master
Review: https://review.openstack.org/580387

Fix proposed to branch: master
Review: https://review.openstack.org/580664

Fix proposed to branch: master
Review: https://review.openstack.org/580665

Fix proposed to branch: master
Review: https://review.openstack.org/580666

Fix proposed to branch: master
Review: https://review.openstack.org/580672

Fix proposed to branch: master
Review: https://review.openstack.org/581029

Fix proposed to branch: master
Review: https://review.openstack.org/581364

Fix proposed to branch: master
Review: https://review.openstack.org/582956

Reviewed: https://review.openstack.org/574781
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=679481f374c969d4887fe686f342dd04ab918b62
Submitter: Zuul
Branch: master

commit 679481f374c969d4887fe686f342dd04ab918b62
Author: Bence Romsics <email address hidden>
Date: Tue Jun 12 16:40:30 2018 +0200

    Mechanism driver API: responsible_for_rsc_provider

    Allow mechanism manager to query drivers if they are responsible for a
    resource provider or not.

    Change-Id: Iea76d85c532b6bded2654062997738295ffc2f5b
    Needed-By: https://review.openstack.org/574783
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/584903

Fix proposed to branch: master
Review: https://review.openstack.org/584906

Fix proposed to branch: master
Review: https://review.openstack.org/584927

Fix proposed to branch: master
Review: https://review.openstack.org/586567

Fix proposed to branch: master
Review: https://review.openstack.org/586597

Reviewed: https://review.openstack.org/580387
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=e77c9befd4677c847a6afff4cb164b02cceb9352
Submitter: Zuul
Branch: master

commit e77c9befd4677c847a6afff4cb164b02cceb9352
Author: Lajos Katona <email address hidden>
Date: Thu Jul 5 15:32:33 2018 +0200

    Ingress direction for min bandwidth rule

    Make possible to have ingress direction for QoS minimum_bandwidth_rule.
    This will not automatically mean that the enforcement will work on the
    dataplane for both directions.
    The actual plan is to have only placement based enforcement for both
    egress and ingress for all reference (sriov, ovs, linuxbridge)
    implementations.

    Change-Id: I4605376ea578ce8a20d83ed95f28d23f8fa82951
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/588319

Fix proposed to branch: master
Review: https://review.openstack.org/590363

Fix proposed to branch: master
Review: https://review.openstack.org/592323

Related fix proposed to branch: master
Review: https://review.openstack.org/592380

Related fix proposed to branch: master
Review: https://review.openstack.org/592757

Reviewed: https://review.openstack.org/580664
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=203f4f06961481e4013dd11c0e74afb9ffe354a4
Submitter: Zuul
Branch: master

commit 203f4f06961481e4013dd11c0e74afb9ffe354a4
Author: Bence Romsics <email address hidden>
Date: Fri Jul 6 15:22:50 2018 +0200

    Placement client: ensure_resource_provider

    All other API resources (ie. traits, resource_provider_traits and
    resource_provider_inventories) we need to report on for minimum
    guaranteed bandwidth have update methods that can be called in one go,
    either because they have update-or-create or update-overrides-all
    semantics. Here we add the 'ensure_resource_provider' method so
    resource providers also have a similarly simple way of being kept in
    sync. We also add 'update_resource_provider' as a pre-requisite. On
    the side we also fix a little, silent unit test type error.

    Change-Id: Ib615ceeb323970d179ffb3dee14e52cb40e73ae7
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/580665
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=74c62da3b5076015563b9f8fe269818546db66cb
Submitter: Zuul
Branch: master

commit 74c62da3b5076015563b9f8fe269818546db66cb
Author: Bence Romsics <email address hidden>
Date: Fri Jul 6 15:25:06 2018 +0200

    Placement client: optional RP generations

    The Placement API has the concept of resource provider generations to
    enable the co-ordination of multiple API clients, so they can avoid
    accidentally overwriting each other's updates.

    However when we know that a single client writes certain resource
    providers then the generation handling becomes an unnecessary extra
    API round-trip. Ideally the Placement API would give us a chance to
    express our ignorance about multi-client coordination (accepting that
    a single client can overwrite its own previous updates).

    Until the Placement API gives us such a feature we implement it in
    the client lib, by making 'resource_provider_generation' parameters
    optional. This is inferior to the API doing the same because we may
    still see GenerationConflict exceptions even when we said
    method(..., resource_provider_generation=None).

    Later changes for the minimum guaranteed bandwidth
    feature need 'resource_provider_generation' to be
    optional for 'update_resource_provider_traits' and
    'update_resource_provider_inventories'. For the sake of consistency
    we do the same to 'update_resource_provider_inventory'.

    Change-Id: I4312c3f8819f7c5b74b68f6fa0507e42094eab79
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/592380
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=d32e570361a636531a2a143fdf004a81e3e28894
Submitter: Zuul
Branch: master

commit d32e570361a636531a2a143fdf004a81e3e28894
Author: Bence Romsics <email address hidden>
Date: Thu Aug 16 14:37:55 2018 +0200

    Placement client: move to neutron_lib.placement

    Move neutron_lib.clients.placement to neutron_lib.placement.client
    with the intent of consolidating all Placement code under
    neutron_lib.placement.

    Change-Id: I48babd7e8d9fddb4c072f12515676dff1c08ef17
    Related-Bug: #1578989

Reviewed: https://review.openstack.org/580666
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=b271a336b13c0d8d6b5ef0078412d87040094747
Submitter: Zuul
Branch: master

commit b271a336b13c0d8d6b5ef0078412d87040094747
Author: Bence Romsics <email address hidden>
Date: Fri Jul 6 15:32:40 2018 +0200

    Placement: constants

    Introduce a constants file for later use for symbols in Placement,
    including constants for:

    * custom trait prefixes
    * resource class names (though that should be replaced as soon as we
      have an os-resource-classes package)
    * known inventory parameters to validate config options

    Change-Id: I3a5afd04ce8b5919efdb7591e3717742dd27151e
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/577220
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=579e0ccabbd5ec132366fe51f46be653cbf15986
Submitter: Zuul
Branch: master

commit 579e0ccabbd5ec132366fe51f46be653cbf15986
Author: Bence Romsics <email address hidden>
Date: Fri Jul 6 15:33:12 2018 +0200

    Placement: utils

    * to generate Placement trait names,
    * to generate Placement resource provider UUIDs, and
    * to uniformly parse and validate Placement-related config options in
      all agents.

    Change-Id: I192d99673feba97a95af995923b266e2f8b58c6d
    Needed-By: https://review.openstack.org/577223
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/584903
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=061a77b4f2d2c8c000b475ee034841a6096c9465
Submitter: Zuul
Branch: master

commit 061a77b4f2d2c8c000b475ee034841a6096c9465
Author: Lajos Katona <email address hidden>
Date: Tue Jul 17 17:31:05 2018 +0200

    Introduce Port resource request extension

    The resources needed by a port are expressed to nova via
    resource_request extending the port.
    If the port requested by nova boot has resource_request attribute, that
    means that placement must enforce the minimum bandwidth requirements.

    Change-Id: I53a77c4d0aa951480abef614febf810772400621
    Needed-By: https://review.openstack.org/584906
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/592757
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=28e07d4c5eb9eec0c51f0e6b055c8ded64bc2d13
Submitter: Zuul
Branch: master

commit 28e07d4c5eb9eec0c51f0e6b055c8ded64bc2d13
Author: Hongbin Lu <email address hidden>
Date: Thu Aug 16 22:24:27 2018 +0000

    Doc: update the qos devref about SR-IOV support

    SR-IOV has added support for enforcing egress minimum bandwidth [1]
    and this commit updates the devref about that.

    [1] https://review.openstack.org/#/c/347302/

    Change-Id: I0e637b893e60d7fdfb1ab4cece15aad74f43d3b5
    Related-Bug: #1578989

Reviewed: https://review.openstack.org/592323
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=9f32a2d04ee0462bfc5099f1878c5a72667182c1
Submitter: Zuul
Branch: master

commit 9f32a2d04ee0462bfc5099f1878c5a72667182c1
Author: Lajos Katona <email address hidden>
Date: Thu Aug 16 10:41:43 2018 +0200

    api-ref: Add port-resource-request extension

    Change-Id: If345ef3ac910ea0a57044f026a2fb74a46882fd9
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/600002

Fix proposed to branch: master
Review: https://review.openstack.org/600409

Fix proposed to branch: master
Review: https://review.openstack.org/601600

Fix proposed to branch: master
Review: https://review.openstack.org/605079

Fix proposed to branch: master
Review: https://review.openstack.org/606034

Change abandoned by Lajos Katona (<email address hidden>) on branch: master
Review: https://review.openstack.org/605079

Fix proposed to branch: master
Review: https://review.openstack.org/609368

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/609724

Reviewed: https://review.openstack.org/581029
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=360fde9f88cb9fbddcfacc399ed6bfa18ebbfe30
Submitter: Zuul
Branch: master

commit 360fde9f88cb9fbddcfacc399ed6bfa18ebbfe30
Author: Lajos Katona <email address hidden>
Date: Mon Jul 9 13:37:25 2018 +0200

    Ingress direction for min bandwidth rule

    Add API extension for QoS minimum bw rule ingress direction.

    Change-Id: I6747652df0372ab2ee480a97758501edba0f5b3f
    Depends-On: https://review.openstack.org/580387
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/609368
Committed: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/commit/?id=b1c48b668855aae30e5c692b93976cb3f87fdf74
Submitter: Zuul
Branch: master

commit b1c48b668855aae30e5c692b93976cb3f87fdf74
Author: Lajos Katona <email address hidden>
Date: Wed Oct 10 13:47:17 2018 +0200

    Remove test_rule_create_fail_for_direction_ingress

    When the API extension qos-bw-minimum-ingress will be on master (see:
    https://review.openstack.org/584927) the test
    neutron_tempest_plugin.api.test_qos.QosMinimumBandwidthRuleTestJSON.
    test_rule_create_fail_for_direction_ingress is useless, so it can be
    removed from master, and to keep the coverage for stable branches there
    should be fullstack test: I6ee08d43aed60a7dd2d3281deaccfac2f3712b33

    Change-Id: Ie04d53817c1f28b4756b1cc308203dc77dd2a19c
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/584927
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4df02ee93cd3c77d2d0bba0f5c1574c22b477eea
Submitter: Zuul
Branch: master

commit 4df02ee93cd3c77d2d0bba0f5c1574c22b477eea
Author: Lajos Katona <email address hidden>
Date: Mon Jul 23 14:52:20 2018 +0200

    Enable ingress direction for min_bw rule

    Enable QoS minimum-bandwidth rule for ovs and sriov backends for both
    ingress and egress directions.
    Add qos-bw-limit-direction as supported extension to qos-plugin, and
    add create/delete/update_minimum_bandwidth and
    delete_minimum_bandwidth_ingress empty methods to sriov/ovs/linuxbridge
    extension drivers.

    Change-Id: I6eb21ccf0400ea9adae90ff0bf97e08cdb09b8eb
    Depends-On: https://review.openstack.org/609368
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/584906
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eb4221e6f0b48b131f2009168b3b22f5a3d4dd8f
Submitter: Zuul
Branch: master

commit eb4221e6f0b48b131f2009168b3b22f5a3d4dd8f
Author: Lajos Katona <email address hidden>
Date: Wed Jul 18 12:41:27 2018 +0200

    Introduce Port resource request extension

    The resources needed by a port are expressed to nova via
    resource_request extending the port.
    If the port requested by nova boot has resource_request attribute, that
    means that placement must enforce the minimum bandwidth requirements.

    Change-Id: I82afa56fa784fc43fefd1ce494bff649f51ad1c8
    Depends-On: https://review.openstack.org/584903
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/577223
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f352f9faaa2927709ec3863035e6b619e5fc34b1
Submitter: Zuul
Branch: master

commit f352f9faaa2927709ec3863035e6b619e5fc34b1
Author: Bence Romsics <email address hidden>
Date: Tue Jul 10 15:37:52 2018 +0200

    ovs-agent: Report resource info in heartbeat

    Example config for ovs-agent:

    ml2_conf.ini:
    [ovs]
    bridge_mappings = physnet0:br-test
    resource_provider_bandwidths = br-test:100000:100000

    Agent configurations now includes 'resource_provider_bandwidths' and
    'resource_provider_inventory_defaults'.

    Change-Id: Ib197573e5cdb60ef0db4e7a771c3179bf9d5bb95
    Co-Authored-By: Lajos Katona <email address hidden>
    Depends-On: https://review.openstack.org/577220
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/582956
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f849eba286e87d51424e1e768619680297ada5cb
Submitter: Zuul
Branch: master

commit f849eba286e87d51424e1e768619680297ada5cb
Author: Lajos Katona <email address hidden>
Date: Mon Jul 16 15:31:44 2018 +0200

    Add both directions for minimum bw rule in doc

    Changed QoS backend/rule support table in devref documentation to show
    that Minimum Bandwidth rule can support both Egress and Ingress
    directions in case of placement based enforcement.
    Added a new table to show which directions are supported for Minimum
    Bandwidth rule by the network backends, and how that depends on the
    enforcement type (dataplane or placement).

    Change-Id: I97ab4815d134d306917a84a7b308b734d6db2dd2
    Depends-On: https://review.openstack.org/580387
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/601600
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a85c5ed3fb1d0cf9af14b976a233c682ffa89c6b
Submitter: Zuul
Branch: master

commit a85c5ed3fb1d0cf9af14b976a233c682ffa89c6b
Author: Lajos Katona <email address hidden>
Date: Fri Sep 28 09:32:37 2018 +0200

    supported_vnic_type configurable for ovs

    Now supported_vnic_types is hardcoded to the mechanism drivers, but that
    can depend on several factors, like type of the NIC, admin decision,
    etc.
    With this patch we put the right to decide which vnic types are
    supported for ovs agent into the hands of the admin, by allowing
    blacklisting items from the mechanism driver specific list.
    Background: http://eavesdrop.openstack.org/meetings/neutron_qos/2018/
    neutron_qos.2018-07-31-15.00.log.html#l-58

    Change-Id: I63e562e2eccc5b02c1c767d6a2c28cb803131e99
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/581364
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d7d433f7290517c4e68290e46e6bcb859f1930a4
Submitter: Zuul
Branch: master

commit d7d433f7290517c4e68290e46e6bcb859f1930a4
Author: Bence Romsics <email address hidden>
Date: Mon Jul 9 16:16:52 2018 +0200

    sriov-agent: Report resource info in heartbeat

    Example config for sriov-agent:

    sriov_agent.ini:
    [sriov_nic]
    physical_device_mappings = physnet0:ens5,physnet0:ens6
    resource_provider_bandwidths = ens5:100000:100000,ens6:100000:100000

    Agent configurations now includes 'resource_provider_bandwidths' and
    'resource_provider_inventory_defaults'.

    Change-Id: I1af798d404ed94cd30da3f92734bea911bbc3ac7
    Co-Authored-By: Lajos Katona <email address hidden>
    Depends-On: https://review.openstack.org/577220
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/598463
Committed: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/commit/?id=dc9c6d6dbe12dd0f760d54edfef84d58551a30a7
Submitter: Zuul
Branch: master

commit dc9c6d6dbe12dd0f760d54edfef84d58551a30a7
Author: Lajos Katona <email address hidden>
Date: Mon Aug 27 16:08:51 2018 +0200

    test for minimum bw ingress direction

    Change-Id: I29fdbf51164aedc0b1a40055532f414cdf8cd4e8
    Depends-On: https://review.openstack.org/584927
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/600002
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=277c1e77b2e5ac2e281a4178cd4c679d96e45c83
Submitter: Zuul
Branch: master

commit 277c1e77b2e5ac2e281a4178cd4c679d96e45c83
Author: Lajos Katona <email address hidden>
Date: Thu Aug 30 14:38:41 2018 +0200

    ovs-agent: fullstack test resource info report

    Change-Id: Ia36b05c835339fea8913103dffad1422a9aacaed
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/609724
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8f549935c7b1597d6b40fc66b59df87708fadec0
Submitter: Zuul
Branch: stable/rocky

commit 8f549935c7b1597d6b40fc66b59df87708fadec0
Author: Lajos Katona <email address hidden>
Date: Wed Oct 10 15:06:03 2018 +0200

    Fullstack test for minimum bw rule ingress create

    With the introduction of qos-bw-minimum-ingress direction the tempest
    test neutron_tempest_plugin.api.test_qos.
    QosMinimumBandwidthRuleTestJSON.
    test_rule_create_fail_for_direction_ingress is useless, but to keep the
    coverage on stable branches that test is backported as neutron fullstack
    test.

    Change-Id: I6ee08d43aed60a7dd2d3281deaccfac2f3712b33
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/586596
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8bd5ecd4fc0c7c6199983c710c62b1ad88039a4f
Submitter: Zuul
Branch: master

commit 8bd5ecd4fc0c7c6199983c710c62b1ad88039a4f
Author: Bence Romsics <email address hidden>
Date: Fri Jul 27 14:19:58 2018 +0200

    notification: Add 'status' to agent after_create/update

    Make the same status information available to notification consumers
    (resource==agent, event==after_create/after_update) as it was already
    available where the notification is sent in class AgentDbMixin.

    Change-Id: Ie74091da934c7e49fd29ae4c6f930a7eb47e14b2
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/606034
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d860109bf60421a721e5009ca6f66a767bfd3488
Submitter: Zuul
Branch: master

commit d860109bf60421a721e5009ca6f66a767bfd3488
Author: Lajos Katona <email address hidden>
Date: Fri Sep 28 10:08:10 2018 +0200

    supported_vnic_type configurable for sriov

    Now supported_vnic_types is hardcoded to the mechanism drivers, but that
    can depend on several factors, like type of the NIC, admin decision,
    etc.
    With this patch we put the right to decide which vnic types are
    supported for ovs agent into the hands of the admin, by allowing
    blacklisting items from the mechanism driver specific list.
    Background: http://eavesdrop.openstack.org/meetings/neutron_qos/2018/
    neutron_qos.2018-07-31-15.00.log.html#l-58

    Change-Id: Iad9e2e966df53b4164d2a56a93215c69825b5241
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/600409
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9b23e1be07a8d686a403ba8939ec5ac79d4ebc74
Submitter: Zuul
Branch: master

commit 9b23e1be07a8d686a403ba8939ec5ac79d4ebc74
Author: Lajos Katona <email address hidden>
Date: Wed Sep 5 14:04:17 2018 +0200

    sriov-agent: fullstack test resource info report

    Change-Id: Ibbe656707276d6c3c68b051e6d66d6d388dbfd18
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/616194

Reviewed: https://review.openstack.org/586597
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=69d6b86f56cff0af76edc30fd01148e79fdd688a
Submitter: Zuul
Branch: master

commit 69d6b86f56cff0af76edc30fd01148e79fdd688a
Author: Bence Romsics <email address hidden>
Date: Tue Jul 24 15:13:15 2018 +0200

    ovs/sriov mech drivers: resource_provider_uuid5_namespace

    Set a UUID v5 namespace for the Open vSwitch mechanism driver and
    another for the SR-IOV mechanism driver. These will be used to
    deterministically generate Placement Resource Provider UUIDs.

    Change-Id: I365a0aeefffe68bd7d5ba5f6697b814bf2713a19
    Depends-On: https://review.openstack.org/586567
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/617711

Reviewed: https://review.openstack.org/617711
Committed: https://git.openstack.org/cgit/openstack/neutron-specs/commit/?id=2af53625e7a2e39e53db394f97328e6427cd9fb9
Submitter: Zuul
Branch: master

commit 2af53625e7a2e39e53db394f97328e6427cd9fb9
Author: Bence Romsics <email address hidden>
Date: Tue Nov 13 16:48:02 2018 +0100

    Adapt to changed resource class names

    Before the final merge of the minimum bandwidth resource classes
    they got renamed in Nova and Placement. So we have to adapt.

    This change retroactively updates the spec.

    Change-Id: Ia347c71381ec2fd82a1b197f5d0fbed69a70ad70
    Partial-Bug: #1578989
    See-Also: I996bf705b14b564106426a2e57299638fb178750
    See-Also: https://review.openstack.org/616194

Reviewed: https://review.openstack.org/616194
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=b2ad10386ba6fd3a8f999b851755b15ce772bf28
Submitter: Zuul
Branch: master

commit b2ad10386ba6fd3a8f999b851755b15ce772bf28
Author: Bence Romsics <email address hidden>
Date: Wed Nov 7 14:15:07 2018 +0100

    Adapt to changed resource class names

    Before the final merge of the minimum bandwidth resource classes
    they got renamed in Nova and Placement. So we have to adapt.

    The previous names were never released or used in any other way
    outside of WIP patches, so there's no upgrade impact.

    Change-Id: Ib81d3a6b312ab7d63df9b5dc97c20d32c3fb214c
    Partial-Bug: #1578989
    See-Also: I996bf705b14b564106426a2e57299638fb178750
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Related fix proposed to branch: master
Review: https://review.openstack.org/619300

Related fix proposed to branch: master
Review: https://review.openstack.org/619301

Related fix proposed to branch: master
Review: https://review.openstack.org/619302

Reviewed: https://review.openstack.org/619300
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=74600f1d9c3a285a838d403ea9194ff9bd714163
Submitter: Zuul
Branch: master

commit 74600f1d9c3a285a838d403ea9194ff9bd714163
Author: Bence Romsics <email address hidden>
Date: Wed Aug 15 11:24:50 2018 +0200

    Placement client: clean up docstrings

    Many :raises: and :returns: are missing from the docstrings.
    This patch adds them and clarifies the wording in a few places.

    Change-Id: If642cf94b04f63bfaca1eb2f6c8c3c6e27c26c00
    Related-Bug: #1578989

Reviewed: https://review.openstack.org/619301
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=5227491b8abfdabe8d6c3625f2bb544cc7cfb7e8
Submitter: Zuul
Branch: master

commit 5227491b8abfdabe8d6c3625f2bb544cc7cfb7e8
Author: Bence Romsics <email address hidden>
Date: Wed Nov 21 17:07:55 2018 +0100

    Placement client: do not swallow exceptions

    Placement client unconditionally swallowed many exceptions. I cannot
    tell why that was ever considered a good idea. I can imagine some
    users wanting to ignore some of those error conditions, but it should
    be the responsibility of the user to decide. The client should not
    unconditionally ignore all errors, but leave this choice for the user
    of the client.

    Particularly this placement client will be used by later patches for
    minimum-bandwidth-allocation-placement-api where we do want to know
    about some of these errors and retry placement operations when they
    fail.

    Change-Id: Ia14ba8cb273166fe3075328229f30d0cebae0480
    Related-Bug: #1578989

Reviewed: https://review.openstack.org/619302
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=1e6a07c5fc8275b11044091cfbd0b580d3a0ebd3
Submitter: Zuul
Branch: master

commit 1e6a07c5fc8275b11044091cfbd0b580d3a0ebd3
Author: Bence Romsics <email address hidden>
Date: Wed Nov 21 17:12:51 2018 +0100

    Placement client: improve Placement 4xx exceptions

    For 4xx errors Placement sends back a complex JSON object describing
    the error. When turned into an exception that becomes a non-trivial
    attribute of the error object. Usual ways of logging an exception (that
    is LOG.exception) completely ignore that attribute, therefore the real
    error message is not logged. For example we only logged the fact that
    we received a BadRequest response and nothing else while Placement did
    provide a whole lot more detail. Here we dig out that error detail and
    re-throw a better exception with it.

    Change-Id: Id97116c1c298f54f898a746d6e3c96b1f412bb49
    Related-Bug: #1578989

Fix proposed to branch: master
Review: https://review.openstack.org/625253

Reviewed: https://review.openstack.org/616594
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=97c9c4656dd208fb34bd300bbcde058cfe9a1944
Submitter: Zuul
Branch: master

commit 97c9c4656dd208fb34bd300bbcde058cfe9a1944
Author: Lajos Katona <email address hidden>
Date: Thu Sep 20 16:54:19 2018 +0200

    get_standard_device_mappings for mechdriver

    get_mappings for machanism drivers return back different dicts for
    different mechanism drivers. By adding get_standard_device_mappings
    method SRIOV and OVS mechanism drivers can return a mapping dict in a
    form like this one:
    {'physnet_name': ['device_or_bridge_1', 'device_or_bridge_2']}

    Change-Id: Ieddd9b3a4f3d7269aafc373f040c55b025f5c201
    Related-Bug: #1578989

Fix proposed to branch: master
Review: https://review.openstack.org/626210

Reviewed: https://review.openstack.org/590363
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e78f82e64fbdc1feac6aaccb108aa5100b0f49ed
Submitter: Zuul
Branch: master

commit e78f82e64fbdc1feac6aaccb108aa5100b0f49ed
Author: Lajos Katona <email address hidden>
Date: Fri Jul 20 17:04:46 2018 +0200

    Fill port-resource-request

    port-resource-request is an admin-only, read-only attribute for neutron
    ports. The content of this field is filled from the QoS minimum
    bandwidth rule attached to the port.

    Change-Id: Ic9862a1b5e24eb798d67823ac3bacab9e54420d8
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/628176

Reviewed: https://review.openstack.org/628176
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ecfbc141480c41d1579b1d7fb205c55de2c6e9d6
Submitter: Zuul
Branch: master

commit ecfbc141480c41d1579b1d7fb205c55de2c6e9d6
Author: Lajos Katona <email address hidden>
Date: Thu Jan 3 14:27:33 2019 +0100

    port-resource-request policy rule to constant

    Change-Id: I14a0b7615b0cda890d5f9a31945de4162737c6aa
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Change abandoned by Lajos Katona (<email address hidden>) on branch: master
Review: https://review.openstack.org/625253
Reason: BAsed on discussion in neutron meeting (see: http://eavesdrop.openstack.org/irclogs/%23openstack-meeting/%23openstack-meeting.2018-12-18.log.html#t2018-12-18T15:17:17)
this test should be in tempest repo, as it will test nova and neutron functioality as well.

Reviewed: https://review.openstack.org/598423
Committed: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/commit/?id=2f90465f73c42dac3eaf7e70c666d44d286e1a4b
Submitter: Zuul
Branch: master

commit 2f90465f73c42dac3eaf7e70c666d44d286e1a4b
Author: Lajos Katona <email address hidden>
Date: Thu Aug 23 14:04:56 2018 +0200

    tests for port-resource-request

    Change-Id: Ib72b01cb25ccdaa00b2b364dca7f8e485aaaf46b
    Depends-On: https://review.openstack.org/590363
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/630662

Fix proposed to branch: master
Review: https://review.openstack.org/630999

Fix proposed to branch: master
Review: https://review.openstack.org/631793

Reviewed: https://review.openstack.org/630662
Committed: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/commit/?id=7eb6725c80615dc0e2b46deb1f892f3af6a38d42
Submitter: Zuul
Branch: master

commit 7eb6725c80615dc0e2b46deb1f892f3af6a38d42
Author: Lajos Katona <email address hidden>
Date: Mon Jan 14 12:55:35 2019 +0100

    Make provider network creation more error proof

    Change-Id: I4bdd3e1effbc49cb3a1ada195c491e823619fa59
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/626210
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=5dcccd2c668a0ae62aa04a6a5f3e390fb56e0053
Submitter: Zuul
Branch: master

commit 5dcccd2c668a0ae62aa04a6a5f3e390fb56e0053
Author: Bence Romsics <email address hidden>
Date: Wed Dec 19 15:49:52 2018 +0100

    New agent attribute: resources_synced

    Agents supporting the guaranteed minimum bandwidth feature need to share
    their resource view with neutron-server and in turn with Placement too.
    The resource information is synchronized to neutron-server via the
    periodic agent heartbeat therefore transient synchronization errors are
    fixed by the next heartbeat. But synchronization to Placement is not
    done periodically, but on a (mostly) on demand basis. Therefore to fix
    transient errors of the synchronization to Placement we must remember
    the success/failure of the last synchronization attempt.

    This change introduces a new boolean agent attribute: resources_synced

    This attribute is:
    * admin-only (just like the whole agent extension)
    * read-only (it is only updated by the internal synchronization process)

    If this attribute is not set then no synchronization to Placement ever
    happened (which is the natural state of agents not tracking their
    resources via Placement).

    If it is False, then another successful synchronization is needed before
    the contents of Placement can be considered up to date.

    If it is True, then this agent's resources are up to date in Placement.

    Change-Id: Ia3dea82fabe5e068192fbe931db8d341d3d37149
    Needed-By: https://review.openstack.org/630999
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/635160

Reviewed: https://review.openstack.org/635160
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=b71eaf4256a2887fa80b61760c633e0d5c37340c
Submitter: Zuul
Branch: master

commit b71eaf4256a2887fa80b61760c633e0d5c37340c
Author: Bence Romsics <email address hidden>
Date: Wed Feb 6 14:53:22 2019 +0100

    Exceptions for: Drive binding by placement allocation

    New exception types used in https://review.openstack.org/574783.

    Change-Id: I46d89ef6d7630ec2c44d619c022aa8bbb6e51b63
    Needed-By: https://review.openstack.org/574783
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/636970

Fix proposed to branch: master
Review: https://review.openstack.org/638666

Reviewed: https://review.openstack.org/636970
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=facc4e94cae64b6c79cd4538e452e838436eac0f
Submitter: Zuul
Branch: master

commit facc4e94cae64b6c79cd4538e452e838436eac0f
Author: Bence Romsics <email address hidden>
Date: Mon Feb 11 14:47:31 2019 +0100

    Reject QoS minimum bandwidth rule updates for bound ports as NotImplemented

    Updating QoS policies and rules backed by resources tracked in Placement
    is a complex task, which was left out of scope for the Stein release.
    Of course this is only relevant for policies/rules already in use on
    bound ports. Rules of unbound ports can still be updated freely.

    Please note this patch cannot catch all possible problems. There will
    always be a time window between the allocation committed to Placement
    and Nova sending the port binding request to Neutron. If the policy or
    rule is changed in this window we cannot do anything against it.

    APIImpact: Reject QoS minimum bandwidth policy/rule updates for bound
               ports as NotImplemented

    Change-Id: I477edb0ae35b385ac776a58195f22382e2fce4ed
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/630999
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=648ab82a4bf07845b97c5cb62347fbde86cdc9d2
Submitter: Zuul
Branch: master

commit 648ab82a4bf07845b97c5cb62347fbde86cdc9d2
Author: Bence Romsics <email address hidden>
Date: Wed Dec 19 13:44:37 2018 +0100

    New agent attribute: resources_synced

    Agents supporting the guaranteed minimum bandwidth feature need to share
    their resource view with neutron-server and in turn with Placement too.
    The resource information is synchronized to neutron-server via the
    periodic agent heartbeat therefore transient synchronization errors are
    fixed by the next heartbeat. But synchronization to Placement is not
    done periodically, but on a (mostly) on demand basis. Therefore to fix
    transient errors of the synchronization to Placement we must remember
    the success/failure of the last synchronization attempt.

    This change implements the extension 'agent-resources-synced' and
    therefore extends the agent db model and object with a new attribute:
    'resources_synced'. This attribute in only meant to be updated
    internally. But it can be read via the API for debugging purposes.

    APIImpact: The agent resource has a new attribute: resources_synced.

    Change-Id: I757d659cea63c8172ca3618d1f581d10236f5e71
    Depends-On: https://review.openstack.org/626210
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/588319
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4ab00d347126127758e12112e081886bb112810d
Submitter: Zuul
Branch: master

commit 4ab00d347126127758e12112e081886bb112810d
Author: Bence Romsics <email address hidden>
Date: Thu Aug 2 10:28:43 2018 +0200

    Class to represent Placement state and sync

    Represent the desired state of the Placement DB and provide a method to
    sync this state to Placement. This is unused as is. A later patch in
    the same series is going to use it. But it is broken out into its own
    file and patch, so the code is organized better and easier to review.

    Change-Id: I3728117f90b7fad2423c2a4276db214ec86c9d8e
    Depends-On: https://review.openstack.org/570847
    Depends-On: https://review.openstack.org/577220
    Depends-On: https://review.openstack.org/616194
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/580672
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9e8e987e6c3d2fa753701689b9ff5d1227fb3c24
Submitter: Zuul
Branch: master

commit 9e8e987e6c3d2fa753701689b9ff5d1227fb3c24
Author: Bence Romsics <email address hidden>
Date: Fri Jul 6 16:02:15 2018 +0200

    Placement reporting service plugin

    This service plugin synchronizes ML2 mechanism driver agents' resource
    information to Placement. To use this service an agent must add
    'resource_provider_bandwidths' to the 'configurations' field of its
    RPC heartbeat. It also may add 'resource_provider_inventory_defaults'
    to fine tune Placement inventory parameters. Again to use this service a
    mechanism driver must implement get_standrd_device_mappings() and allocate
    a UUID as mechanism driver property 'resource_provider_uuid5_namespace'.

    The synchronization is triggered by:
    * any new agent object in the DB
    * restart of an agent (via 'start_flag' in the RPC heartbeat)
    * if an agent's 'resources_synced' attribute is not True (None/False)

    The latter should autoheal transient errors of the synchronization
    process. That is if a sync attemp fails then we store
    resources_synced=False which triggers a sync retry at each new heartbeat
    message until a sync attempt finally succeeds and we can set
    resources_synced=True.

    Since this code functionally depends on ML2 we can also consider making
    it part of ML2, but at the moment it is a service plugin for better
    decoupling. Even if you load the service plugin the logic gracefully
    degrades for heartbeat messages not containing resource provider info.

    If needed the sync can be forced in multiple ways. First, if you restart
    an agent then the RPs belonging to that agent will be re-synced. You may
    also delete the agent by 'openstack network agent delete' and let the
    next heartbeat message re-create the agent object. On re-creation the
    RPs belonging to that agent will be re-synced. On the other hand a
    neutron-server restart does not trigger a re-sync in any way. Depending
    on the trade-off between the admin's needs to force re-syncs and the
    performance of (not absolutely necessary) Placement updates re-sync
    conditions may be further fine tuned.

    Example config for neutron-server:

    neutron.conf:
    [DEFAULT]
    service_plugins = placement

    Change-Id: Ia1ff6f7559ab77913ddb9c3b134420a401b8eb43
    Co-Authored-By: Lajos Katona <email address hidden>
    Depends-On: https://review.openstack.org/586567
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/574783
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=74c51a2e5390f258290ee890c9218beb5fdfd29c
Submitter: Zuul
Branch: master

commit 74c51a2e5390f258290ee890c9218beb5fdfd29c
Author: Bence Romsics <email address hidden>
Date: Tue Jun 26 11:16:54 2018 +0200

    Drive binding by placement allocation

    Drive the choice of mechanism driver during binding as inferred from
    the resource provider allocated by nova and as told to neutron via the
    port's binding:profile.

    As discussed on a neutron qos irc meeting some time ago
    this patch introduces a new assumption on bind_port() implementations.
    That is an implementation of bind_port() in any mech driver supporting
    Guaranteed Minimum Bandwidth bind_port() must not have a non-idempotent
    side effect. Because the last binding level will be redone for a 2nd
    time with a narrowed down list of mechanism drivers. And if the 2nd call
    does not give the same result as the first all kind of weird things can
    happen.

    Change-Id: I2b7573ec6795170ce45a13d5d0ad7844fb85182d
    Depends-On: https://review.openstack.org/574781
    Depends-On: https://review.openstack.org/635160
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Fix proposed to branch: master
Review: https://review.openstack.org/642527

Related fix proposed to branch: master
Review: https://review.openstack.org/645104

Related fix proposed to branch: master
Review: https://review.openstack.org/645210

Reviewed: https://review.openstack.org/640390
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=252598b08827c0cd5e5c4174f84b4196c59f7493
Submitter: Zuul
Branch: master

commit 252598b08827c0cd5e5c4174f84b4196c59f7493
Author: Bence Romsics <email address hidden>
Date: Wed Feb 27 08:41:29 2019 +0100

    Networking guide: Guaranteed Minimum Bandwidth

    High-level overall and low-level neutron docs for the
    Guaranteed Minimum Bandwidth feature.

    Change-Id: I27224250956b3b940d6372bd46afbdd11e0ce284
    Closes-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/645104
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7cccaf0616efe1f5b7d75d22ef0c3e1f7c649b16
Submitter: Zuul
Branch: master

commit 7cccaf0616efe1f5b7d75d22ef0c3e1f7c649b16
Author: Bence Romsics <email address hidden>
Date: Wed Mar 20 17:17:02 2019 +0100

    FUP Networking guide: Guaranteed Minimum Bandwidth

    Being so close to the rc1 deadline I didn't want to lose +2s of
    https://review.openstack.org/640390, so review comments are fixed here.

    Change-Id: Ic3353dd34bbc9fe6c1e03395d095067238fac844
    Related-Bug: #1578989
    Related-Change: https://review.openstack.org/640390
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

This issue was fixed in the openstack/neutron 14.0.0.0rc1 release candidate.

Reviewed: https://review.openstack.org/645210
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3e008fd51b12a81c404870a7fb1d01f82363907b
Submitter: Zuul
Branch: master

commit 3e008fd51b12a81c404870a7fb1d01f82363907b
Author: Bence Romsics <email address hidden>
Date: Thu Mar 21 16:36:04 2019 +0100

    FUP: Unit tests for https://review.openstack.org/636970

    I forgot to add unit tests to the original change.
    This patch adds the missing unit tests.

    Change-Id: If281f9a8c33864fa18a3b8a8de854816f5773efe
    Related-Bug: #1578989
    Related-Change: https://review.openstack.org/636970
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/631793
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=092c6d68511b43fd975f6fccc4a697488966ff5e
Submitter: Zuul
Branch: master

commit 092c6d68511b43fd975f6fccc4a697488966ff5e
Author: Lajos Katona <email address hidden>
Date: Wed Jan 16 16:36:55 2019 +0100

    Agent configuration bandwidth report change

    Fullstack test for checking if agent configuration field's
    resource_provider_bandwidths changes after configuration file change and
    agent restart.

    Change-Id: I655777d27645d9a6eaf8b134d77cd2951404aef9
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.openstack.org/638666
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=3ec5a22c762544ff2cf36fc7d1e0214cb285ea1a
Submitter: Zuul
Branch: master

commit 3ec5a22c762544ff2cf36fc7d1e0214cb285ea1a
Author: Lajos Katona <email address hidden>
Date: Thu Feb 7 13:26:14 2019 +0100

    Add noauth option for placement client

    To make possible the fullstack testing of bandwidth reporting towards
    placement and syncing of resources, we have to start a small process, a
    fake placement that can answer back placement REST API requests.
    For this we have to add a noauth client to bypass keystone in case of
    fullstack testing.

    Change-Id: I199157e47f05f3b21eed15a1eb39b31a009030dd
    Needed-By: https://review.openstack.org/642527
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Reviewed: https://review.opendev.org/642527
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d4d2fbc30df45eadea724de8698023ec5ffbb6ba
Submitter: Zuul
Branch: master

commit d4d2fbc30df45eadea724de8698023ec5ffbb6ba
Author: Lajos Katona <email address hidden>
Date: Mon Jan 21 10:44:18 2019 +0100

    Fullstack test for placement sync

    Fullstack test for placement reporter service plugin. To test it in
    fullstack environment a new stupid placement process is started which
    answers to placement REST API requests.

    Change-Id: I9dd9f6c9e8c8fcf1be1e91d49a59a00c2eb24026
    Depends-On: https://review.openstack.org/638666
    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)

Related fix proposed to branch: master
Review: https://review.opendev.org/660687

Fix proposed to branch: master
Review: https://review.opendev.org/660924

Reviewed: https://review.opendev.org/660687
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d10ba94d36da7ad7eb6ac9339bcac81ab169b93e
Submitter: Zuul
Branch: master

commit d10ba94d36da7ad7eb6ac9339bcac81ab169b93e
Author: Bence Romsics <email address hidden>
Date: Wed May 22 13:01:17 2019 +0200

    Log when the placement service plugin is used wrongly

    Log explicitly when an invalid plugin combination is requested in the
    config.

    The placement service plugin cannot be used with non-ML2 core
    plugins. neutron-server already exits when misconfigured like that
    (when a plugin raises an uncaught exception in its __init__())
    so I didn't change anything about that. This change only adds a more
    explicit log message for this misconfiguration.

    Change-Id: Ida1a3188f8b3145cf270d280bf942b3950c0779c
    Related-Bug: #1578989
    Related-Bug: #1818479

Reviewed: https://review.opendev.org/660924
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4445b380cffaae4898359c878f3a1900d86e44d7
Submitter: Zuul
Branch: master

commit 4445b380cffaae4898359c878f3a1900d86e44d7
Author: Lajos Katona <email address hidden>
Date: Wed May 22 16:59:52 2019 +0200

    Add devstack plugin for placement service plugin

    This helps running end-to-end tests in gate, see:
    https://review.opendev.org/629253

    Partial-Bug: #1578989
    See-Also: https://review.openstack.org/502306 (nova spec)
    See-Also: https://review.openstack.org/508149 (neutron spec)
    Change-Id: I6732909a10114dbc004043b754d47d974c3fe1cb

Related fix proposed to branch: master
Review: https://review.opendev.org/706875

Reviewed: https://review.opendev.org/706875
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=37fafeb6781504b506e6e399354d808ec8c0e31d
Submitter: Zuul
Branch: master

commit 37fafeb6781504b506e6e399354d808ec8c0e31d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Feb 10 15:06:50 2020 +0000

    Add SR-IOV agent resource provider information

    When the SR-IOV agent starts, print information about the Placement
    resource providers: bandwidth, inventory default configuration and
    hypervisor names.

    Change-Id: Ib34f7a4f850301b2a8bf739c9d8d5e73bcc1bc48
    Related-Bug: #1578989

Related fix proposed to branch: master
Review: https://review.opendev.org/740269

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.opendev.org/740269
Reason: This feature is not going to provide the NUMA policy affinity through the port resource request but using a specific extension. We don't need this refactor.