RetryRequest shouldn't log stack trace by default, or it should be configurable by the exception
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Confirmed
|
Low
|
Unassigned |
Bug Description
I see the following littering the logs and it strikes me as wrong:
2018-12-18 01:01:46.259 34 DEBUG neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
2018-12-18 01:01:46.259 34 ERROR neutron.
Since this is an explicit request by the operation to retry, and not some unexpected behavior, it shouldn't log the stack trace.
If you really want more fine grained control (over not logging the trace completely), a flag can be added to the exception to determine whether the log of it should contain the stack trace or not.
The code in question is here (also on master but this rocky url is simpler):
https:/
Changed in neutron: | |
status: | New → Confirmed |
importance: | Undecided → Low |
summary: |
RetryRequest shouldn't log stack trace by default, or it should be - configuarble by the exception + configurable by the exception |