Able to change vnic type on a bound port

Bug #2033090 reported by Jakub Libosvar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Jakub Libosvar

Bug Description

When a port is bound, it's still possible to change its vnic type. This doesn't make sense and the operation should not be allowed.

Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/892815

Changed in neutron:
status: New → In Progress
Revision history for this message
Lajos Katona (lajos-katona) wrote :

As I wrote on the review it can be something to discuss, but currently PUT is allowed on the API:

https://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/api/definitions/portbindings_extended.py#L87

https://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/api/definitions/portbindings.py#L187

so I would add a doc entry (perhaps to the api-ref at least) that PUT works only for UNBOUND ports

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lib (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-lib/+/900826

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892815
Committed: https://opendev.org/openstack/neutron/commit/354205a42372ce2480b14a5e9b80eb0d91991b37
Submitter: "Zuul (22348)"
Branch: master

commit 354205a42372ce2480b14a5e9b80eb0d91991b37
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 25 01:52:24 2023 +0000

    Forbid updating vnic type on a bound port

    The vnic type should not be changed once the port is bound since it's
    related to the actual port binding. The patch validates the port update
    operation and fails the update if the vnic type is attempted to be
    changed on a bound port.

    Closes-bug: #2033090
    Change-Id: I5cb79d9da96ba41a7787083c81f522c328fae049
    Signed-off-by: Jakub Libosvar <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-lib (master)

Reviewed: https://review.opendev.org/c/openstack/neutron-lib/+/900826
Committed: https://opendev.org/openstack/neutron-lib/commit/b99cfa600419a2252b7a6d6476e6a07fe8ad429b
Submitter: "Zuul (22348)"
Branch: master

commit b99cfa600419a2252b7a6d6476e6a07fe8ad429b
Author: Jakub Libosvar <email address hidden>
Date: Mon Nov 13 21:50:37 2023 +0000

    api-ref: Document only unbound ports vnic_type updates

    The Neutron patch linked below changes behavior of API update requests
    to vnic_type port binding attribute on bound ports. It's no longer
    allowed to update the vnic_type if the port is already bound.

    Depends-On: https://review.opendev.org/c/openstack/neutron/+/892815
    Related-bug: #2033090
    Change-Id: Ic5c6d54a1e5e57e977623ac6a4e2e6278f7237b7
    Signed-off-by: Jakub Libosvar <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 24.0.0.0b1

This issue was fixed in the openstack/neutron 24.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.