OpenDaylight MD should not ignore 400 errors

Bug #1369239 reported by Cédric OLLIVIER
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Cédric OLLIVIER
Icehouse
New
Undecided
Unassigned
Juno
Fix Released
Undecided
Unassigned

Bug Description

400 (Bad Request) errors are ignored in every create or update operation to OpenDaylight. Referring to the comment, it protects against conflicts with already existing resources.

In case of update operations, it seems irrelevant and masks "real" bad requests. It could also be removed in create operations.

Cédric OLLIVIER (m.col)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121407

Changed in neutron:
assignee: nobody → Cédric OLLIVIER (m.col)
status: New → In Progress
Cédric OLLIVIER (m.col)
tags: added: juno-rc-potential
Thierry Carrez (ttx)
tags: added: juno-backport-potential
removed: juno-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/121407
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f1507d080d9840e4cb6c1d5cfe5a4b6c1443bd8f
Submitter: Jenkins
Branch: master

commit f1507d080d9840e4cb6c1d5cfe5a4b6c1443bd8f
Author: Cédric Ollivier <email address hidden>
Date: Sun Sep 14 13:04:21 2014 +0200

    Stop ignoring 400 errors returned by ODL

    This commit stops ignoring 400 (Bad Request) HTTP codes returned by ODL
    in create and update operations. It also modifies sendjson() because it
    doesn't ignore any HTTP error code now.

    Change-Id: Id0db2c0c1d8fddfbd16b3ce9476a2358e2ef1e49
    Closes-Bug: #1369239

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/133657

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/juno)

Reviewed: https://review.openstack.org/133657
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fe7c2331e3dd8fdd524b3f9bd896831824a50b1c
Submitter: Jenkins
Branch: stable/juno

commit fe7c2331e3dd8fdd524b3f9bd896831824a50b1c
Author: Cédric Ollivier <email address hidden>
Date: Sun Sep 14 13:04:21 2014 +0200

    Stop ignoring 400 errors returned by ODL

    This commit stops ignoring 400 (Bad Request) HTTP codes returned by ODL
    in create and update operations. It also modifies sendjson() because it
    doesn't ignore any HTTP error code now.

    Change-Id: Id0db2c0c1d8fddfbd16b3ce9476a2358e2ef1e49
    Closes-Bug: #1369239
    (cherry picked from commit f1507d080d9840e4cb6c1d5cfe5a4b6c1443bd8f)

tags: added: in-stable-juno
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/136553

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/136553
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ffa6294a1ee6faea34e285b7d5f3442e0bf29436
Submitter: Jenkins
Branch: stable/icehouse

commit ffa6294a1ee6faea34e285b7d5f3442e0bf29436
Author: Cédric Ollivier <email address hidden>
Date: Sun Sep 14 13:04:21 2014 +0200

    Stop ignoring 400 errors returned by ODL

    This commit stops ignoring 400 (Bad Request) HTTP codes returned by ODL
    in create and update operations. It also modifies sendjson() because it
    doesn't ignore any HTTP error code now.

    Closes-Bug: #1369239
    Change-Id: Id0db2c0c1d8fddfbd16b3ce9476a2358e2ef1e49
    (cherry picked from commit f1507d080d9840e4cb6c1d5cfe5a4b6c1443bd8f)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.