OpenStack Compute (nova)

The 'uri' input validation of jsonschema does not work

Bug #1326599 reported by Ken'ichi Ohmichi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Ian Cordasco
OpenStack Compute (nova) 2014.2 "juno"

Bug Description

Now the 'uri' format validation of jsonschema library should be used for
API input validation, but it does not work.

In jsonschema library, it tries to import rfc3987 library for 'uri'
vaildation. And if it fails, jsonschema does not check 'uri' format.
Now requirements.txt of Nova does not contain rfc3987 and the 'uri'
validation does not work.

Tags: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/98011

Revision history for this message
Ken'ichi Ohmichi (oomichi) wrote :

The license of the library rfc3987 is GPL, and we cannot add it to requirements.
https://review.openstack.org/#/c/98012/

So we need the other workaround for this problem.

Tracy Jones (tjones-i)
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/98011
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=67057e823ab5a003ed54055f9708d78ed13eb01a
Submitter: Jenkins
Branch: master

commit 67057e823ab5a003ed54055f9708d78ed13eb01a
Author: Ken'ichi Ohmichi <email address hidden>
Date: Fri Jun 6 10:26:59 2014 +0900

    Add unit tests for ipv4/ipv6 format validation

    We found a bug that the other jsonschema format check('uri') did
    not work for input validation. There was not any unit tests for
    the format check, then we could not find it in long term.
    The bug is fixed with Ibb2b7f27c374136e6865b28786d10ca1365e5709 .
    And this patch adds unit tests for the format 'ipv4' and 'ipv6'.

    Change-Id: I6f6636708e3f9a4eee14451f2baacb50002f1db8
    Related-Bug: #1326599

Ken'ichi Ohmichi (oomichi)
Changed in nova:
assignee: nobody → Ken'ichi Ohmichi (oomichi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Ken'ichi Ohmichi (<email address hidden>) on branch: master
Review: https://review.openstack.org/98006
Reason: The other better patch I288fbaead64990db1053b7a11e82904611b8498f is being proposed.

Ian Cordasco (icordasc)
Changed in nova:
assignee: Ken'ichi Ohmichi (oomichi) → Ian Cordasco (icordasc)
Sean Dague (sdague)
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Ian Cordasco (icordasc) wrote :

sdague, this was fixed and merged https://review.openstack.org/#/c/103688/.

Changed in nova:
status: Confirmed → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.