OpenStack Compute (nova)

KeyError in nova.compute.api.API.external_instance_event

Bug #1348584 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Salvatore Orlando
OpenStack Compute (nova) 2014.2 "juno"
Icehouse
Fix Released
Medium
Attila Fazekas
OpenStack Compute (nova) 2014.1.2

Bug Description

The fix for bug 1333654 ensured events for instance without host are not accepted.
However, the instances without the host are still being passed to the compute API layer.

This is likely to result in keyerrors as the one found here: http://logs.openstack.org/51/109451/2/check/check-tempest-dsvm-neutron-full/ad70f74/logs/screen-n-api.txt.gz#_2014-07-25_01_41_48_068

The fix for this bug should be straightforward.

Salvatore Orlando (salvatore-orlando)
Changed in nova:
assignee: nobody → Salvatore Orlando (salvatore-orlando)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109551

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/109551
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5e4a5f0d8c62ca6e94ae6db16e9fbe0428805158
Submitter: Jenkins
Branch: master

commit 5e4a5f0d8c62ca6e94ae6db16e9fbe0428805158
Author: Salvatore Orlando <email address hidden>
Date: Fri Jul 25 04:19:10 2014 -0700

    Do not pass instances without host to compute API

    Even if the server external events extension filters out events
    whose related instance does not have a host, the corresponding
    instance is still sent to the compute API module.
    As this might result in KeyError, instance without host should
    be filtered out before calling the compute API module.

    Change-Id: If5229ec3059076dbc9f4abb6625504e8864c265e
    Closes-Bug: #1348584

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/109799

Alan Pevec (apevec)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/icehouse)

Reviewed: https://review.openstack.org/109799
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7de0132e409a27eb1a12db035535ff68e5e561f9
Submitter: Jenkins
Branch: stable/icehouse

commit 7de0132e409a27eb1a12db035535ff68e5e561f9
Author: Salvatore Orlando <email address hidden>
Date: Fri Jul 25 04:19:10 2014 -0700

    Do not pass instances without host to compute API

    Even if the server external events extension filters out events
    whose related instance does not have a host, the corresponding
    instance is still sent to the compute API module.
    As this might result in KeyError, instance without host should
    be filtered out before calling the compute API module.

    Change-Id: If5229ec3059076dbc9f4abb6625504e8864c265e
    Closes-Bug: #1348584
    (cherry picked from commit 5e4a5f0d8c62ca6e94ae6db16e9fbe0428805158)

Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.