OpenStack Compute (nova)

An Ironic node should not be exposed to Nova if no Ironic port is associated with it

Bug #1582663 reported by Zhenguo Niu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
In Progress
Medium
Unassigned

Bug Description

We should check whether there are ports associated with the node during verifying process, then we can enroll a node without any port, but it can't be available to nova.

Zhenguo Niu (niu-zglinux)
Changed in ironic:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Revision history for this message
Mathieu Mitchell (mat128) wrote :

It might be weird, but a node without any physical port could be a valid configuration. You could have out of band means of accessing the machine (serial console, graphical console).

Revision history for this message
Zhenguo Niu (niu-zglinux) wrote :

@mat128, yes, without port could be a valid configuration, you can still do oob operation from ironic side, but I'm talking about not exposed the node to nova to waste scheduling, as currently if a nova boot scheduled to a node without any port, it will raise an error that the node is not ready to deploy.

Revision history for this message
Dmitry Tantsur (divius) wrote :

Moving this to Nova, as Ironic does not control what Nova tracks.

affects: ironic → nova
summary: - Node should not exposed to nova if no port associated with it
+ An Ironic node should not be exposed to Nova if no Ironic port is
+ associated with it
tags: added: ironic
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

@Zhenguo Niu:
I'm not sure I understand what you said. Is this about scheduling? What exactly is the "verifying process" and the "enrollment of a node"?

Changed in nova:
status: New → Incomplete
tags: added: scheduler
Markus Zoeller (markus_z) (mzoeller)
tags: removed: scheduler
Revision history for this message
Markus Zoeller (markus_z) (mzoeller) wrote :

After discussing with jroll and zhenguo in #openstack-nova [1] it seems to be valid and hit this area [2].

References:
[1] http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2016-05-24.log.html#t2016-05-24T12:55:24
[2] https://github.com/openstack/nova/blob/d2875b78b5746bfcb082a7c5385375d704518581/nova/virt/ironic/driver.py#L166-L166

Changed in nova:
status: Incomplete → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/321014

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/321014
Reason: This looks abandoned. If you plan on continuing with it, please restore, rebase and address review feedback.

Revision history for this message
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in nova:
status: In Progress → Confirmed
assignee: Zhenguo Niu (niu-zglinux) → nobody
Dmitry Tantsur (divius)
tags: added: low-hanging-fruit
Hesam Chobanlou (hesamchobanlou)
Changed in nova:
assignee: nobody → Hesam Chobanlou (hesamchobanlou)
Hesam Chobanlou (hesamchobanlou)
Changed in nova:
assignee: Hesam Chobanlou (hesamchobanlou) → nobody
Revision history for this message
Vladyslav Drok (vdrok) wrote :

What if you have custom boot, deploy interfaces, and use 'none' network, and you don't need an ironic port to be present?

Hesam Chobanlou (hesamchobanlou)
Changed in nova:
assignee: nobody → Hesam Chobanlou (hesamchobanlou)
Hesam Chobanlou (hesamchobanlou)
Changed in nova:
status: Confirmed → In Progress
Hesam Chobanlou (hesamchobanlou)
Changed in nova:
assignee: Hesam Chobanlou (hesamchobanlou) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.