OpenStack Compute (nova)

build_and_run_instance can error out with an UnboundException

Bug #1854848 reported by Erik Olof Gunnar Andersson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
In Progress
Undecided
XiaojueGuan

Bug Description

If for some reason eventlet throws a timeout during a build event on the compute a eventlet.Timeout exception might be thrown and cause an UnboundException. This is because we only catch Exception, but Timeout is based on BaseException.
https://github.com/openstack/nova/blob/7babcdfd1d440c484d49d45ffe4f81264cdc4f73/nova/compute/manager.py#L2075

http://paste.openstack.org/show/786939/

Revision history for this message
Matt Riedemann (mriedem) wrote :

Rather than change https://github.com/openstack/nova/blob/7babcdfd1d440c484d49d45ffe4f81264cdc4f73/nova/compute/manager.py#L2075 to catch BaseException I would probably just have it also catch eventlet.Timeout and/or initialize the result variable before the try/except/finally block.

tags: added: compute
Changed in nova:
status: New → Triaged
tags: added: low-hanging-fruit
XiaojueGuan (xiaojuegaun)
Changed in nova:
assignee: nobody → XiaojueGuan (xiaojuegaun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/698140

Changed in nova:
status: Triaged → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.