[SRU] Nova-manage network delete does not delete from fixed_ips

This has been a bug since Cactus and still seems to be present in master. This should really be fixed for Essex. The enclosed patch works on stable/diablo, haven't tested against master.

wow this still hasn't been fixed? :(

Fix proposed to branch: master
Review: https://review.openstack.org/6174

Reviewed: https://review.openstack.org/6174
Committed: http://github.com/openstack/nova/commit/761e4e0cbe12b9d196f8e63146dce9513718ece1
Submitter: Jenkins
Branch: master

commit 761e4e0cbe12b9d196f8e63146dce9513718ece1
Author: Vishvananda Ishaya <email address hidden>
Date: Tue Apr 3 11:30:57 2012 -0700

    Delete fixed_ips when network is deleted

     * adds failing test
     * adds exception that is raised when network is in use
     * fixes bug 754900

    Change-Id: Ib95dc5927561b979b1eea237d4d6dc323483d4a5

Fix proposed to branch: stable/essex
Review: https://review.openstack.org/6664

Reviewed: https://review.openstack.org/6664
Committed: http://github.com/openstack/nova/commit/015744e92e601036ddcd77bd2fbed966172cb759
Submitter: Jenkins
Branch: stable/essex

commit 015744e92e601036ddcd77bd2fbed966172cb759
Author: Vishvananda Ishaya <email address hidden>
Date: Tue Apr 3 11:30:57 2012 -0700

    Delete fixed_ips when network is deleted

     * adds failing test
     * adds exception that is raised when network is in use
     * fixes bug 754900

    Change-Id: Ib95dc5927561b979b1eea237d4d6dc323483d4a5

Bug workaround documented in https://review.openstack.org/7337

The attachment "db_sqlalchemy_api_network_delete_fixed_ips.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

** Impact **

When the network is deleted from nova the Fixed IP addresses associated are not deleted as well. This results in IP address that are no longer used and cannot be delete.

** Devevlopment Fix **

This has been addressed in https://review.openstack.org/#/c/6174/ and fixed already for quantal.

** Stable Fix **

This fix has been backported to the stable/essex tree in https://review.openstack.org/6664

** Test Case **

A test case has been added called "test_network_delete_safe". Run the nova test suite by running ./run_tests.sh -N with all the build dependencies installed

** Regression Potential **

Minimal, this is a bug that has been around forever.

Hello justinsb, or anyone else affected,

Accepted nova into precise-proposed. The package will build now and be available in a few hours. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Please find the attached Jenkins job results from the Ubuntu Server Team's CI
infrastructure. As part of the verification process for this bug, Nova has
been deployed and configured across multiple nodes using precise-proposed as
an installation source. After successful bring-up and configuration of the
cluster, a number of exercises and smoke tests have be invoked to ensure the
updated package did not introduce any regressions. A number of test iterations
were carried out to catch any possible transient errors.

Note the list of installed packages at the top and bottom of the report.

For records of upstream test coverage of this update, please see the
Jenkins links in the comments of the relevant upstream code-review:

https://review.openstack.org/6664

As per the provisional Micro Release Exception granted to this package by
the Technical Board, we hope this contributes toward verification of this
update.

This bug was fixed in the package nova - 2012.1+stable~20120612-3ee026e-0ubuntu1

---------------
nova (2012.1+stable~20120612-3ee026e-0ubuntu1) precise-proposed; urgency=low

  * New upstream snapshot. (LP: #1010473)
  * Dropped, superseeded by new snapshot:
    - debian/patches/upstream/0001-fix-bug-where-nova-ignores-glance-host-in-imageref.patch
    - debian/patches/upstream/0002-Stop-libvirt-test-from-deleting-instances-dir.patch
    - debian/patches/upstream/0003-Allow-unprivileged-RADOS-users-to-access-rbd-volumes.patch
    - debian/patches/upstream/0004-Fixed-bug-962840-added-a-test-case.patch
    - debian/patches/upstream/0005-Populate-image-properties-with-project_id-again.patch
    - debian/patches/upstream/0006-Use-project_id-in-ec2.cloud._format_image.patc
    - debian/patches/CVE-2012-2101.patch
    - debian/patches/CVE-2012-2654.patch
  * Resynchronize with stable/essex:
    - 3ee026e Only invoke .lower() on non-None protocols. (LP: #1010514)
    - f0a9f47 Create a utf8 version of the dns_domains table. (LP: #993663)
    - 84a43e1 Report memory correctly on Xen. (LP: #997014)
    - 8c72924 Add libvirt get_console_output tests: pty and file. (LP: #990237)
    - 4e423cd Fix Multi_Scheduler to process host capabilities. (LP: #1000403)
    - 4aea7f1 Nail pep8 dependencies to 1.0.1
    - 2b3bbc4 handle updated qemu-img info output. (LP: #1000261)
    - 2d7d51c Fix type of snapshot_id column to match db. (LP: #962615)
    - ec70c69 Generate a Changelog for Nova
    - e5e890f Fix nova.tests.test_nova_rootwrap on Fedora 17. (LP: #992916)
    - 9e9a554 Ec2 handle strings with "0x" (LP: #983206)
    - 26dc6b7 QuantumManager will start dnsmasq during startup. Fixes (LP: #977759)
    - 7028d66 Introduced flag base_dir_name. (LP: #973194)
    - 76b525a Get unit tests functional in OS X.
    - facb936 Update KillFilter to handle 'deleted' exe's. (LP: #967931)
    - 1209af4 Checks if value is string or not before decode. (LP: #952176)
    - 1209af4 Fix timeout in EC2 CloudController.create_image(). (LP: #989764)
    - 108e74b Re-add console_log from console_console_output(). (LP: #987335)
    - 48a0768 Don't leak RPC connections on timeouts or other exceptions. (LP: #968843)
    - 7c64de9 Cloudpipe tap vpn not always working. (LP: #975043)
    - 5ab5051 add libvirt_inject_key flag fix (LP: #971640)
    - 6c68ef5 Xen: Pass session to destroy_vdi. (LP: #988615)
    - 015744e Delete fixed_ips when network is deleted. (LP: #754900)
  * Add debian/scripts/changelog.sh to help generate the changelog.
  * Add debian/nova-common.docs:
    - Include changelog and README.rst
  * debian/rules: Generate a tarball from git snapshot.
  * debian/patches/fix-pep8-errors.patch: Fix pep8 errors due to pep8 upstream
    migration.
 -- Chuck Short <email address hidden> Tue, 05 Jun 2012 09:50:59 -0400