OpenStack Compute (nova)

ironic.peer_list config help is wrong

  1. Series stein
  2. Bug #1827094
Bug #1827094 reported by Jim Rollenhagen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Jim Rollenhagen
Stein
Fix Committed
Medium
Matt Riedemann

Bug Description

This help text currently implies that the host reading the config does not need to be in the peer list, when in fact it does: https://opendev.org/openstack/nova/src/commit/ce5ef763b58cad09440e0da67733ce578068752a/nova/virt/ironic/driver.py#L142

Tags: ironic
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: nobody → Jim Rollenhagen (jim-rollenhagen)
status: New → In Progress
Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

Patch is here: https://review.opendev.org/#/c/656549

melanie witt (melwitt)
tags: added: ironic
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/656549
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=674c004231a3f7696962d7a7bfa69b4b31af4de8
Submitter: Zuul
Branch: master

commit 674c004231a3f7696962d7a7bfa69b4b31af4de8
Author: Jim Rollenhagen <email address hidden>
Date: Tue Apr 30 12:57:22 2019 -0400

    Fix help for ironic.peer_list config

    This implied that the current host did not need to be in this list;
    however, it does.

    Closes-Bug: #1827094
    Change-Id: I4fe9df6b3789ae0365900d546d49121b99ea2a44

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/656632

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/656632
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b123b05a4866d4ad0868fba33964982f686ac57f
Submitter: Zuul
Branch: stable/stein

commit b123b05a4866d4ad0868fba33964982f686ac57f
Author: Jim Rollenhagen <email address hidden>
Date: Tue Apr 30 12:57:22 2019 -0400

    Fix help for ironic.peer_list config

    This implied that the current host did not need to be in this list;
    however, it does.

    Closes-Bug: #1827094
    Change-Id: I4fe9df6b3789ae0365900d546d49121b99ea2a44
    (cherry picked from commit 674c004231a3f7696962d7a7bfa69b4b31af4de8)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.1

This issue was fixed in the openstack/nova 19.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 20.0.0.0rc1

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.