OpenERP Community Backports (Addons)

[6.1][7.0][trunk]Pricelist doesn't take category depth into account

Bug #1169074 reported by Yann Papouin on 2013-04-15

This bug affects 3 people

	Status	Importance	Assigned to
Odoo Addons (MOVED TO GITHUB)	Confirmed	Medium	OpenERP R&D Addons Team 2
OpenERP Community Backports (Addons)	Status tracked in 7.0
6.1	Fix Released	Medium	Yann Papouin
7.0	Fix Committed	Medium	Yann Papouin

Bug Description

Attached is a proposal that fix this issue

eg: If you create two rules:

- Apply a discount of 25% on products in category A with sequence 5
- Apply a discount of 50% on products in category B (where B is a child of A) with sequence 5

Depending on the order of these two lines, your product could have a discount of 25% OR 50% (that's a random order from postgresql)

The sequence number (the only way to make priority) is not usable here as you have to manually link the sequence number with the category depth !!! That's impossible to do when you have 6 and more levels of category.

In my patch, the category depth is first computed then used in the result order

Tags:

Related branches

lp://qastaging/~yann-papouin/openobject-addons/6.1-bug-1169074-pricelist-category-depth

Ready for review for merging into lp://qastaging/openobject-addons/6.1

OpenERP Core Team: Pending requested 2013-09-05

lp://qastaging/~yann-papouin/ocb-addons/6.1-bug-1169074-pricelist-category-depth

Merged into lp://qastaging/ocb-addons/6.1 at revision 6812

Holger Brunn (Therp): Approve on 2013-10-14

lp://qastaging/~yann-papouin/openobject-addons/7.0-bug-1169074-pricelist-category-depth

Ready for review for merging into lp://qastaging/openobject-addons/7.0

OpenERP Core Team: Pending requested 2014-03-10

lp://qastaging/~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth

Rejected for merging into lp://qastaging/ocb-addons

Holger Brunn (Therp): Disapprove on 2014-11-24

Guewen Baconnier @ Camptocamp: Needs Information on 2014-03-21

Yannick Vaucher @ Camptocamp: Approve (code review, no test) on 2014-03-10

Revision history for this message

Yann Papouin (yann-papouin) wrote on 2013-04-15:

pricelist.py.diff Edit (3.9 KiB, text/x-diff)

Yann Papouin (yann-papouin) on 2013-05-03

summary:

- Pricelist doesn't take category depth into account
+ [6.1][7.0][trunk]Pricelist doesn't take category depth into account

Revision history for this message

Amit Bhavsar (Open ERP) (amb-openerp) wrote on 2013-05-22:

Pricelist_depth.ogv Edit (13.4 MiB, video/ogg)

Hello Yaan,

I have checked your Issue with latest revision. But It's seems fine. That's why I have attached screen cast for your reference. so would you please check It and notify us where you have faced the problem.

Thanks and waiting for your reply!

Changed in openobject-addons:
status:	New → Incomplete

Revision history for this message

Yann Papouin (yann-papouin) wrote on 2013-05-22:

lp_1169074.ogv Edit (17.7 MiB, video/ogg)

Please see my demo:
I've done exactly like you, except that in a second part, I'm switching pricelist item content:

Before:
RULE 1 : Sequence 5 - Discount 25% on CatA
RULE 2 : Sequence 5 - Discount 50% on CatB

After (by editing content):
RULE 1 : Sequence 5 - Discount 50% on CatB
RULE 2 : Sequence 5 - Discount 25% on CatA

As you can see the result is not the same at all !!!

Yann Papouin (yann-papouin) on 2013-05-22

Changed in openobject-addons:
status:	Incomplete → New

Revision history for this message

Amit Parik (amit-parik) wrote on 2013-07-19:

Hello Yann.

Thanks for the video and detailed explanation!

Faced the same problem at my end.

Thank you!

Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
importance:	Undecided → Medium
status:	New → Confirmed