OEM Priority Project

[ubiquity] need to implement a reboot mechanism before oobe

Bug #1867711 reported by hugh chao on 2020-03-17

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OEM Priority Project	Fix Released	Critical	hugh chao
	ubiquity (Ubuntu)	Fix Released	High	Unassigned

Bug Description

Some oem projects preload workaround(configuration/dkms/firmware....) in the image, and it need a reboot to take effect in OOBE(oem-config) stage, but current ubiquity doesn't support this feature..

https://code.launchpad.net/~hugh712/ubiquity/+git/ubiquity/+merge/380808

[test case]

1. Boot to "OEM install (for manufactures)" with usb sticker.
2. Finish the 1st configuration(default settings) and start to install the system.
3. Finish the installation and reboot.
4. Login to the desktpop.
5. CLick "Prepare for shipping to en..." on the desktop.
6. Reboot after the dialog "oem-config will run the next time the system boots" be shown.
7. Reboot.
8. Finish the 2nd configuration(oem-config), just use default settings.
9. Let the system finish the configuration and apply changes.
10. With this patch system will reboot after (9) or it will just go to login page.

See original description

Related branches

~hugh712/ubiquity:need-reboot-1867711

Merged into ubiquity:master at revision 11c0698fc0b7f1660029892135dd9a48fe164dc5

Jean-Baptiste Lallement: Approve on 2020-03-27

hugh chao (hugh712) on 2020-03-17

Changed in oem-priority:
assignee:	nobody → hugh chao (hugh712)
importance:	Undecided → Critical

Revision history for this message

hugh chao (hugh712) wrote on 2020-03-17:

I will verify this commit and send a mp

https://git.launchpad.net/~hugh712/ubuntu/+source/ubiquity/commit/?id=b4b97d1f832d0e786abc13d9812a215a0e3a5a17

Revision history for this message

hugh chao (hugh712) wrote on 2020-03-17:

no, the right repo is this one:

https://code.launchpad.net/~ubuntu-installer/ubiquity/+git/ubiquity/+ref/master

hugh chao (hugh712) on 2020-03-17

Changed in oem-priority:
status:	New → Confirmed

Revision history for this message

hugh chao (hugh712) wrote on 2020-03-18:

verification done, will send a mp to upstream

hugh chao (hugh712) on 2020-03-18

description:

updated

Revision history for this message

hugh chao (hugh712) wrote on 2020-03-18:

https://code.launchpad.net/~hugh712/ubiquity/+git/ubiquity/+merge/380808

Changed in oem-priority:
status:	Confirmed → In Progress

hugh chao (hugh712) on 2020-03-18

Changed in oem-priority:
status:	In Progress → Triaged

hugh chao (hugh712) on 2020-03-18

description:

updated

Revision history for this message

Rex Tsai (chihchun) wrote on 2020-03-24:

I have changed the report to the public.

Please always file bug against to the upstream open source project, and add also affects project to oem-priority. Therefore the core engineering team can see the request.

information type:

Proprietary → Public

Revision history for this message

hugh chao (hugh712) wrote on 2020-03-24:

I just reported it to ubiquity public as
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1868701

Revision history for this message

hugh chao (hugh712) wrote on 2020-03-24:

so I will just close this one

Changed in oem-priority:
status:	Triaged → Invalid

Revision history for this message

Mathew Hodson (mhodson) wrote on 2020-04-08:

ubiquity (20.04.7) focal; urgency=medium

  [ Sebastien Bacher ]
  * debian/control:
    - don't build-depends on xkb-data-i18n which has been merged back
      to xkb-data now

  [ Hugh Chao ]
  * Add a preseed option which can let oem project reboot before OOBE i
    (LP: #1867711)

  [ Rik Mills ]
  * bin/ubiquity-dm: Switch the default KDE Plasma wallpaper looked for
    from .png to .jpg, as Plasma 5.18 switched default extension for
    that release. Fixes no background on the Try/Install screen for
    Kubuntu. (LP: #1863073)

  [ Iain Lane ]
  * In GNOME 3.36 the `gnome-session-x11-services.target` unit gained some
    dependencies that aren't satisfied in the ubiquity-dm environment. So
    GNOME Shell starting up this unit doesn't work any more: go back to the
    old way of starting it directly. (LP: #1869331)
  * ubiquity-dm: gnome-settings-daemon binaries have moved under /usr/libexec
    and adjust the paths accordingly.
  * ubiquity.json: Specify the path to the new theme GResource used by GNOME
    Shell
  * simple-plugins: Clean up the ubuntu-drivers.autoinstall file before each
    run. This file is only ever appended to. The list is computed (passing
    --free-only and/or --no-oem) when leaving the prepare page. So we
    currently have the situation that if you revisit the page after having
    left it, the file is not updated with any new choices but is only appended
    to. Make sure it is written fresh each time, by removing it before running
    ubuntu-drivers.
  * prepare: Detect whether there are OEM enablement package for the system.
    Record this so that it can be used later on when actually installing.
    Installation can be disabled by preseeding ubiquity/install_oem.
  * plugininstall: If we've installed any OEM metapackages, update & upgrade them.
    This is the same as what `ubuntu-drivers autoinstall' is doing. We need
    this to try to ensure that the metapackage is upgraded in the target -
    if we're online when installing. (LP: #1866035)

  [ Jean-Baptiste Lallement ]
  * Updated changelog
  * Automatic update of included source packages: console-setup
    1.194ubuntu3.

-- Iain Lane <email address hidden> Mon, 30 Mar 2020 12:46:20 +0100

ubiquity (20.04.7) focal; urgency=medium

[ Sebastien Bacher ]
  * debian/control:
    - don't build-depends on xkb-data-i18n which has been merged back
      to xkb-data now

[ Hugh Chao ]
  * Add a preseed option which can let oem project reboot before OOBE i
    (LP: #1867711)

[ Iain Lane ]
  * In GNOME 3.36 the `gnome-session-x11-services.target` unit gained some
    dependencies that aren't satisfied in the ubiquity-dm environment. So
    GNOME Shell starting up this unit doesn't work any more: go back to the
    old way of starting it directly. (LP: #1869331)
  * ubiquity-dm: gnome-settings-daemon binaries have moved under /usr/libexec
    and adjust the paths accordingly.
  * ubiquity.json: Specify the path to the new theme GResource used by GNOME
    Shell
  * simple-plugins: Clean up the ubuntu-drivers.autoinstall file before each
    run.  This file is only ever appended to. The list is computed (passing
    --free-only and/or --no-oem) when leaving the prepare page. So we
    currently have the situation that if you revisit the page after having
    left it, the file is not updated with any new choices but is only appended
    to. Make sure it is written fresh each time, by removing it before running
    ubuntu-drivers.
  * prepare: Detect whether there are OEM enablement package for the system.
    Record this so that it can be used later on when actually installing.
    Installation can be disabled by preseeding ubiquity/install_oem.
  * plugininstall: If we've installed any OEM metapackages, update & upgrade them.
    This is the same as what `ubuntu-drivers autoinstall' is doing. We need
    this to try to ensure that the metapackage is upgraded in the target -
    if we're online when installing. (LP: #1866035)

[ Jean-Baptiste Lallement ]
  * Updated changelog
  * Automatic update of included source packages: console-setup
    1.194ubuntu3.

-- Iain Lane <iain.lane@canonical.com>  Mon, 30 Mar 2020 12:46:20 +0100

Changed in ubiquity (Ubuntu):
importance:	Undecided → High
status:	New → Fix Released
Changed in oem-priority:
status:	Invalid → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1868701

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.