kwargs always NoneType
Bug #1255918 reported by
schnere
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
openerp-fiscal-rules |
Fix Released
|
Undecided
|
Guewen Baconnier @ Camptocamp |
Bug Description
Hi,
in account_
So I did a little debugging and found out, that kwargs = context.update() always returns None.
I've fixed this with settings kwargs = context first and the update with kwargs.update.
Next problem is, when shop_id is not set, the if-statement does not what it should do:
if context.
This fix works for me:
if context.
Please see and review my attached patched. I'm looking forward for comments.
Best regards,
schnere
Related branches
lp://qastaging/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918
- Joël Grand-Guillaume @ camptocamp: Approve (code review, no tests)
- Raphaël Valyi - http://www.akretion.com: Approve
- Sébastien BEAU - http://www.akretion.com: Approve (no test, code review)
-
Diff: 33 lines (+8/-7)1 file modifiedaccount_fiscal_position_rule_sale/sale.py (+8/-7)
lp://qastaging/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack
- Sandy Carter (http://www.savoirfairelinux.com): Approve (code review)
- Raphaël Valyi - http://www.akretion.com: Approve
- Yannick Vaucher @ Camptocamp: Approve (code review, no tests)
-
Diff: 20 lines (+2/-3)1 file modifiedaccount_fiscal_position_rule_sale/sale.py (+2/-3)
Changed in openerp-fiscal-rules: | |
status: | New → Confirmed |
assignee: | nobody → Guewen Baconnier @ Camptocamp (gbaconnier-c2c) |
Changed in openerp-fiscal-rules: | |
status: | Confirmed → Fix Released |
To post a comment you must log in.