Optional Split In Song Editor Does Nothing On Output Display Or Preview
Bug #1576148 reported by
Andrew Reyes
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
In Progress
|
Wishlist
|
Azaziah | ||
Bug Description
When using an 'optional split' under song editor and save then preview or go live it does nothing. I'm not sure if we're supposed to us a newline after an 'optional split' or not but I notice no change when using it.
I'm on Linux Gentoo using OpenLP-2.4
Steps to reproduce are again:
1. Select a song in song view
2. Select edit song
3. Select a particular section of a song and select edit (or select edit all)
4. Select optional split in between two lines
5. Select OK
6. Select Save
7. Select Preview of the edited song or go live and nothing has changed
Related branches
lp://qastaging/~suutari-olli/openlp/force-split
- Tim Bentley: Needs Fixing
-
Diff: 250 lines (+118/-11)5 files modifiedopenlp/core/lib/renderer.py (+3/-3)
openlp/plugins/songs/forms/editsongform.py (+49/-0)
openlp/plugins/songs/forms/editversedialog.py (+6/-0)
openlp/plugins/songs/forms/editverseform.py (+44/-5)
tests/functional/openlp_plugins/songs/test_editverseform.py (+16/-3)
| Changed in openlp: | |
| assignee: | nobody → Azaziah (suutari-olli) |
Revision history for this message
| Azaziah (suutari-olli) wrote | #1 |
| Changed in openlp: | |
| status: | New → In Progress |
| importance: | Undecided → Wishlist |
To post a comment you must log in.
Hello Andrew and thank you for reporting.
Optional split means that the song will be only split if it does not fit one slide.
If you want to force the split, you should duplicate the verse tag (EG. Verse1)
I've started working on "Force split" which will always split the verse.
I'll see if I can make it work.
Example of Optional splitting:
Theme supports max 4 lines of text
A
B
<split>
C
D
Output:
A
B
C
D
Theme supports max 3 lines of text
A
B
<split>
C
D
Output:
A
B
New slide
C
D
If no split is used, the output will be:
A
B
C
New slide
D
The meaning of optional split is confusing,