Projector authenticated connection generates exception
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
High
|
Ken Roberts | ||
| 2.4 |
Fix Released
|
Undecided
|
Ken Roberts | ||
Bug Description
Authenticated connection with no pin set should have generated an error message box.
projector.
projector.manager DEBUG (Test Projector) updateStatus(
projector.manager DEBUG (Test Projector) Updating icon with S_CONNECTING
projector.pjlink1 DEBUG (192.168.1.20) check_login(
projector.pjlink1 DEBUG (192.168.1.20) check_login() read "PJLINK 1 44cd859a"
projector.pjlink1 DEBUG (192.168.1.20) data_check=
projector.pjlink1 DEBUG (192.168.1.20) Setting hash with salt="44cd859a"
projector.pjlink1 DEBUG (192.168.1.20) pin="None"
openlp.core.OpenLP DEBUG Entering hook_exception
root CRITICAL Traceback (most recent call last):
File "openlp/
AttributeError: 'NoneType' object has no attribute 'encode'
Related branches
- Tomas Groth: Approve
- Tim Bentley: Approve
-
Diff: 172 lines (+74/-12)5 files modifiedopenlp/core/common/__init__.py (+4/-3)
openlp/core/lib/projector/pjlink1.py (+16/-5)
openlp/plugins/presentations/lib/powerpointcontroller.py (+1/-1)
tests/functional/openlp_core_common/test_projector_utilities.py (+2/-2)
tests/functional/openlp_core_lib/test_projector_pjlink1.py (+51/-1)
- Raoul Snyman: Approve
- Tomas Groth: Approve
-
Diff: 1082 lines (+452/-98)5 files modifiedopenlp/core/common/__init__.py (+2/-1)
openlp/core/lib/projector/constants.py (+5/-1)
openlp/core/lib/projector/pjlink1.py (+125/-83)
tests/functional/openlp_core_common/test_projector_utilities.py (+3/-4)
tests/functional/openlp_core_lib/test_projector_pjlink1.py (+317/-9)
| Changed in openlp: | |
| status: | New → In Progress |
| Ken Roberts (alisonken1) wrote | #1 |
| Changed in openlp: | |
| status: | In Progress → Fix Committed |
| Changed in openlp: | |
| milestone: | none → 2.5.1 |
fix and test pushed to ~alisonken1/openlp/bug-1593883-projector-
Will request merge when bug 1593883 is fixed.