[6.1 / trunk?] customer invoices proposed in bill task work

Hello,

When creating customer invoices for analytic account with to_invoice = Yes, the lines are proposed in the bill task work wizard.

I reproduced on 6.1, but it probably applies to trunk too as the code did not change.

How to reproduce:
- install 6.1 with modules accounting and hr_timesheet_invoice
- create an analytic account where Invoice on Timesheet & Costs (field to_invoice) = Yes (100)%
- create a timesheet line on that account
- in Accounting, run bill task work -> the timesheet line appears -> click Create invoice
- the draft invoice is generated
- run bill task work again -> no line appear -> this is ok, since the timesheet is now invoiced
- validate the invoice
- run bill task work again -> a line re-appear with to_invoice = Yes (but on the sales journal) -> this is wrong

Actually, whenever an accounting move is validated for an analytic account where to_invoice is not null, the to_invoice field is set on the analytic line too, therefore proposing the line for invoicing.

This is incorrect and was working correctly in 6.0.

The problem seems related to the patch introduced with lp:734497. I assume that bug was related to the creation of supplier invoices that the user wants to reinvoice. However, as it works now, customer invoices are also proposed for reinvoicing, which is incorrect.

-sbi