[6.0.1][hr_holidays] can not refuse an approved holidays

Bug #709130 reported by Laurent Urbain (Realdolmen)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Medium
OpenERP R&D Addons Team 3

Bug Description

Hi,

In hr_holidays module,

When a leave is in approved state, there is a button Refuse.
When I click on this button :

  File "/home/laurent/Documents/OpenERP/Trunk/addons/hr_holidays/hr_holidays.py", line 293, in holidays_cancel
    obj_crm_meeting.unlink(cr, uid, [record.case_id])
  File "/home/laurent/Documents/OpenERP/Trunk/addons/base_calendar/base_calendar.py", line 1594, in unlink
    if self.get_edit_all(cr, uid, event_id, vals=None):
  File "/home/laurent/Documents/OpenERP/Trunk/addons/base_calendar/base_calendar.py", line 1417, in get_edit_all
    return meeting['recurrency'] and meeting['edit_all']
TypeError: list indices must be integers, not str

Related branches

Revision history for this message
Laurent Urbain (Realdolmen) (laurent-urbain) wrote :
Revision history for this message
DBR (OpenERP) (dbr-openerp) wrote :

Hello Laurent,

Thanks for reporting.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Medium
status: New → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Bug appear in base_calendar module so moved it to respected team.

thanks,
mra

Changed in openobject-addons:
status: In Progress → Confirmed
assignee: OpenERP R&D Addons Team 3 (openerp-dev-addons3) → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
assignee: OpenERP R&D Addons Team 2 (openerp-dev-addons2) → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Ujjvala Collins (uco-openerp) wrote :

Hello,

We have tested the problem on our side with base_calendar but the problem seems to be in case_id field of hr_holidays module. The error is coming due to the type of that field. It will be better if the type of case_id field is changed to integer rather than char as it stores id of meeting object.

Hope this helps.

Thanks.

Changed in openobject-addons:
status: In Progress → Confirmed
Changed in openobject-addons:
assignee: OpenERP R&D Addons Team 1 (openerp-dev-addons1) → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello,

Converted "char" type into "int" when we refuse the holidays.

I have Fixed the problem in Addons3 branch.
revision-id: mra@mra-laptop-20110131064845-2joefqn4oqh1gob1

Thank you,
mra

Changed in openobject-addons:
status: Confirmed → In Progress
status: In Progress → Fix Released
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Changed the field type to many2one for case_id with rev no 4935 on Addons3 branch.

Changed in openobject-addons:
milestone: none → 6.1
Changed in openobject-addons:
milestone: 6.1 → 6.0.2
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Everyone,

Thanks for your contributions, it has been fixed into stable 6.0.1 by revision 4439 <email address hidden> courtesy Revision 4935 mra@mra-laptop-20110201124038-fwehl3uq7qo3tp6v from branch trunk-dev-addons3.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.